Merged
Conversation
sirasistant
approved these changes
Mar 24, 2025
Contributor
|
Aren't the traces meant to be optimised for "common" txs? I wouldn't classify contract class deployment as "common" enough to optimise the traces? |
PhilWindle
pushed a commit
that referenced
this pull request
Mar 24, 2025
🤖 I have created a new Aztec Packages release --- ## [0.82.2](v0.82.1...v0.82.2) (2025-03-24) ### Features * optimize unconstrained `embedded_curve_add` (noir-lang/noir#7751) ([1e796e2](1e796e2)) * translator zk relation adjustments testing ([#12718](#12718)) ([33e528f](33e528f)) ### Bug Fixes * increased poseidon gates ([#12973](#12973)) ([49d6bfa](49d6bfa)) ### Miscellaneous * bump bb to 0.82.0 (noir-lang/noir#7777) ([1e796e2](1e796e2)) * Fix for e2e gossip network test ([#12954](#12954)) ([5a256c8](5a256c8)) * get logs from init containers ([#12974](#12974)) ([28d1f3e](28d1f3e)) * remove duplication on library list files (noir-lang/noir#7774) ([1e796e2](1e796e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
After this: #12061 we were overflowing the trace on contract class registrations. This was not caught by tests due to: - Insufficient tests with full proving (and the ones we have deploy without proving!) - Insufficient WASM testing: this overflow caused the overflowing trace to go over 4GB
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
🤖 I have created a new Aztec Packages release --- ## [0.82.2](v0.82.1...v0.82.2) (2025-03-24) ### Features * optimize unconstrained `embedded_curve_add` (noir-lang/noir#7751) ([1e796e2](1e796e2)) * translator zk relation adjustments testing ([#12718](#12718)) ([33e528f](33e528f)) ### Bug Fixes * increased poseidon gates ([#12973](#12973)) ([49d6bfa](49d6bfa)) ### Miscellaneous * bump bb to 0.82.0 (noir-lang/noir#7777) ([1e796e2](1e796e2)) * Fix for e2e gossip network test ([#12954](#12954)) ([5a256c8](5a256c8)) * get logs from init containers ([#12974](#12974)) ([28d1f3e](28d1f3e)) * remove duplication on library list files (noir-lang/noir#7774) ([1e796e2](1e796e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
After this: #12061 we were overflowing the trace on contract class registrations. This was not caught by tests due to: - Insufficient tests with full proving (and the ones we have deploy without proving!) - Insufficient WASM testing: this overflow caused the overflowing trace to go over 4GB
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
🤖 I have created a new Aztec Packages release --- ## [0.82.2](v0.82.1...v0.82.2) (2025-03-24) ### Features * optimize unconstrained `embedded_curve_add` (noir-lang/noir#7751) ([1e796e2](1e796e2)) * translator zk relation adjustments testing ([#12718](#12718)) ([33e528f](33e528f)) ### Bug Fixes * increased poseidon gates ([#12973](#12973)) ([49d6bfa](49d6bfa)) ### Miscellaneous * bump bb to 0.82.0 (noir-lang/noir#7777) ([1e796e2](1e796e2)) * Fix for e2e gossip network test ([#12954](#12954)) ([5a256c8](5a256c8)) * get logs from init containers ([#12974](#12974)) ([28d1f3e](28d1f3e)) * remove duplication on library list files (noir-lang/noir#7774) ([1e796e2](1e796e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this: #12061 we were overflowing the trace on contract class registrations. This was not caught by tests due to: