feat: translator zk relation adjustments testing#12718
Merged
maramihali merged 17 commits intomasterfrom Mar 24, 2025
Merged
Conversation
added 10 commits
March 11, 2025 15:15
maramihali
force-pushed
the
mm/relation-adjustment
branch
from
10e59d3 to
98b1f7e
Compare
maramihali
commented
Mar 21, 2025
| * the random values. | ||
| */ | ||
| void TranslatorProvingKey::compute_translator_range_constraint_ordered_polynomials() | ||
| void TranslatorProvingKey::compute_translator_range_constraint_ordered_polynomials(bool masking) |
Author
There was a problem hiding this comment.
This bool masking will go away in the "end product", I wanted to be able to test what I'm doing and it felt like the most non-invasive approach since it doesn't interfere with the rest of the Translator computation normally
ledwards2225
approved these changes
Mar 23, 2025
Contributor
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
Overall looks great. Nice job adding tests. Left one suggestion and some comments about comments.
.../cpp/src/barretenberg/relations/translator_vm/translator_delta_range_constraint_relation.hpp
Outdated
Show resolved
Hide resolved
...src/barretenberg/relations/translator_vm/translator_delta_range_constraint_relation_impl.hpp
Outdated
Show resolved
Hide resolved
...src/barretenberg/relations/translator_vm/translator_delta_range_constraint_relation_impl.hpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/translator_vm/translator_proving_key.cpp
Outdated
Show resolved
Hide resolved
.../cpp/src/barretenberg/relations/translator_vm/translator_delta_range_constraint_relation.hpp
Outdated
Show resolved
Hide resolved
| auto lagrange_masking = View(in.lagrange_masking); | ||
| const auto& gamma = ParameterView(params.gamma); | ||
| const auto& beta = ParameterView(params.beta); | ||
| return (interleaved_range_constraints_0 + lagrange_masking * beta + gamma) * |
Contributor
There was a problem hiding this comment.
this construction (in particular the + lagrange_masking * beta) feels like it deserves some comments, unless its explained elsewhere and I'm missing it. What are we establishing by adding an additional constant to the sum only at the masked indices?
Author
There was a problem hiding this comment.
thanks, will add comments to the declaration of accumulate
PhilWindle
pushed a commit
that referenced
this pull request
Mar 24, 2025
🤖 I have created a new Aztec Packages release --- ## [0.82.2](v0.82.1...v0.82.2) (2025-03-24) ### Features * optimize unconstrained `embedded_curve_add` (noir-lang/noir#7751) ([1e796e2](1e796e2)) * translator zk relation adjustments testing ([#12718](#12718)) ([33e528f](33e528f)) ### Bug Fixes * increased poseidon gates ([#12973](#12973)) ([49d6bfa](49d6bfa)) ### Miscellaneous * bump bb to 0.82.0 (noir-lang/noir#7777) ([1e796e2](1e796e2)) * Fix for e2e gossip network test ([#12954](#12954)) ([5a256c8](5a256c8)) * get logs from init containers ([#12974](#12974)) ([28d1f3e](28d1f3e)) * remove duplication on library list files (noir-lang/noir#7774) ([1e796e2](1e796e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
This PR changes DeltaRangeConstraint and Permutation relation in Translator to operate correctly in the presence of masking data at the end of the polynomials as well as unit tests to establish correctness of the changes given masking is not yet full enabled in Translator.
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
🤖 I have created a new Aztec Packages release --- ## [0.82.2](v0.82.1...v0.82.2) (2025-03-24) ### Features * optimize unconstrained `embedded_curve_add` (noir-lang/noir#7751) ([1e796e2](1e796e2)) * translator zk relation adjustments testing ([#12718](#12718)) ([33e528f](33e528f)) ### Bug Fixes * increased poseidon gates ([#12973](#12973)) ([49d6bfa](49d6bfa)) ### Miscellaneous * bump bb to 0.82.0 (noir-lang/noir#7777) ([1e796e2](1e796e2)) * Fix for e2e gossip network test ([#12954](#12954)) ([5a256c8](5a256c8)) * get logs from init containers ([#12974](#12974)) ([28d1f3e](28d1f3e)) * remove duplication on library list files (noir-lang/noir#7774) ([1e796e2](1e796e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
This PR changes DeltaRangeConstraint and Permutation relation in Translator to operate correctly in the presence of masking data at the end of the polynomials as well as unit tests to establish correctness of the changes given masking is not yet full enabled in Translator.
DanielKotov
pushed a commit
that referenced
this pull request
Mar 27, 2025
🤖 I have created a new Aztec Packages release --- ## [0.82.2](v0.82.1...v0.82.2) (2025-03-24) ### Features * optimize unconstrained `embedded_curve_add` (noir-lang/noir#7751) ([1e796e2](1e796e2)) * translator zk relation adjustments testing ([#12718](#12718)) ([33e528f](33e528f)) ### Bug Fixes * increased poseidon gates ([#12973](#12973)) ([49d6bfa](49d6bfa)) ### Miscellaneous * bump bb to 0.82.0 (noir-lang/noir#7777) ([1e796e2](1e796e2)) * Fix for e2e gossip network test ([#12954](#12954)) ([5a256c8](5a256c8)) * get logs from init containers ([#12974](#12974)) ([28d1f3e](28d1f3e)) * remove duplication on library list files (noir-lang/noir#7774) ([1e796e2](1e796e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes DeltaRangeConstraint and Permutation relation in Translator to operate correctly in the presence of masking data at the end of the polynomials as well as unit tests to establish correctness of the changes given masking is not yet full enabled in Translator.