feat: 64 bit log type id, 64 bit log metadata by benesjan · Pull Request #12956 · AztecProtocol/aztec-packages

benesjan · 2025-03-22T02:13:42Z

We make log type id and log metadata both be 64 bit in preparation for private event logs processing in Noir.

benesjan · 2025-03-22T02:14:00Z

fix: tagging bug #13061
refactor: minor tagging API improvement #13092
feat: purge of log decryption in TS #12992
feat!: processing events in Aztec.nr #12957
feat: 64 bit log type id, 64 bit log metadata #12956 👈 (View in Graphite)
feat: LogEncryption trait #12942
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

noir-projects/aztec-nr/aztec/src/encrypted_logs/log_assembly_strategies/default_aes128/note.nr

nventuro

Looking great!

noir-projects/aztec-nr/aztec/src/discovery/private_logs.nr

nventuro · 2025-03-25T20:30:25Z

noir-projects/aztec-nr/aztec/src/discovery/private_logs.nr

    let expanded_log_metadata = log_plaintext.get(0);

-    let log_type_id = ((expanded_log_metadata as u64) / 128);
-    let log_metadata = ((expanded_log_metadata as u64) % 128);
+    let log_metadata = ((expanded_log_metadata as u128) >> 64) as u64;
+    let log_type_id = (expanded_log_metadata as u64);


Casting and shifting in Noir has always been troublesome. Given we'll continue to update this, extract this snippet into a fn that extracts both u64 from the u128, and let's add a couple tests for it including the edge cases (e.g. 0xffff, 0xffff00000, 0x0000fffff, etc)

Good idea. Addressed in bde6715

noir-projects/aztec-nr/aztec/src/encrypted_logs/log_assembly_strategies/default_aes128/note.nr

noir-projects/aztec-nr/aztec/src/encrypted_logs/log_type.nr

nventuro · 2025-03-25T20:37:12Z

noir-projects/aztec-nr/aztec/src/encrypted_logs/log_assembly_strategies/default_aes128/note.nr

-    fields[0] = Note::get_id();
+    // We pack log type id and log metadata into the first field. Search for `decode_log_plaintext` function to see
+    // where the value gets decoded.
+    fields[0] = (Note::get_id() * 2.pow_32(64)) + log_type_id as Field;


I'd consider creating a function that takes a log type id and log metadata and creates the expanded metadata, i.e. the inverse of the one I sugested before. We'll repeat this snippet for events etc, and it'd be nice to have some simple tests for it.

Good idea. Addressed in bde6715

nventuro · 2025-03-27T01:22:30Z

noir-projects/aztec-nr/aztec/src/utils/u64s_packing.nr

+    }
+
+    #[test]
+    fn roundtrip_two_u64s() {


This could be a fuzz test

Addressed in the last commit

nventuro · 2025-03-27T01:23:53Z

noir-projects/aztec-nr/aztec/src/utils/u64s_packing.nr

+pub fn pack_two_u64s(high: u64, low: u64) -> Field {
+    let low_field = low as Field;
+    // We use multiplication instead of bit shifting operations to shift the high bits as bit shift operations are
+    // expensive in circuits.
+    let high_field: Field = (high as Field) * U64_SHIFT_MULTIPLIER;
+    high_field + low_field
+}
+
+pub fn unpack_two_u64s(input: Field) -> (u64, u64) {
+    input.assert_max_bit_size::<128>();
+    let low = (input as u64);
+    // Use division instead of bit shift since bit shifts are expensive in circuits
+    let high = ((input - (low as Field)) / U64_SHIFT_MULTIPLIER) as u64;
+    (high, low)
+}


I'd not really bother with this being a generic utility - we'll likely never have to do this again. I'd just make this a log encoding specific utility that is rather fn to_expanded_metadata(log_type, log_metadata) and fn from_expanded_metadata. We'll add more similar fns in the future as log encoding becomes more complicated.

Addressed in the one but last commit

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

🤖 I have created a new Aztec Packages release --- ## [0.82.3](v0.82.2...v0.82.3) (2025-03-27) ### Features * `msgpack` encoding for `Program` and `WitnessStack` ([#12841](#12841)) ([1e58eb1](1e58eb1)) * 64 bit log type id, 64 bit log metadata ([#12956](#12956)) ([20d734a](20d734a)) * AVM parsing tag validation ([#12936](#12936)) ([56b1f0d](56b1f0d)) * **avm:** add calldata & returndata to context ([#13008](#13008)) ([f03b2e5](f03b2e5)) * **avm:** merkle db hints (part 1) ([#12922](#12922)) ([34ec9e8](34ec9e8)) * **avm:** merkle hints (part 2) ([#13077](#13077)) ([fbbc6c7](fbbc6c7)) * **avm:** vm2 initial context ([#12972](#12972)) ([e2b1361](e2b1361)) * benchmark avm simulator ([#12985](#12985)) ([00fae1b](00fae1b)) * client flows benchmarks ([#13007](#13007)) ([9bf7568](9bf7568)) * gas benchmark for "normal usage" ([#13073](#13073)) ([4eb1156](4eb1156)) * Implement merkle writes in the merkle check gadget ([#13050](#13050)) ([c94fe50](c94fe50)) * LogEncryption trait ([#12942](#12942)) ([0b7e564](0b7e564)) * Node snapshot sync ([#12927](#12927)) ([afde851](afde851)), closes [#12926](#12926) * **p2p:** capture all gossipsub metrics ([#12930](#12930)) ([cc940cb](cc940cb)) * Prover node snapshot sync ([#13097](#13097)) ([1e77efb](1e77efb)) * staking asset handler ([#12968](#12968)) ([af48184](af48184)), closes [#12932](#12932) * stream crs data to disk ([#12996](#12996)) ([d016e4d](d016e4d)), closes [#12948](#12948) * track failed tests. add flake. ([f4936d7](f4936d7)) * Track test history. ([#13037](#13037)) ([036bb32](036bb32)) * track total tx fee ([#12601](#12601)) ([9612a4e](9612a4e)) * Validators sentinel ([#12818](#12818)) ([770695c](770695c)) ### Bug Fixes * added #[derive(Eq)] to EcdsaPublicKeyNote ([#12966](#12966)) ([0c21c74](0c21c74)) * Allow use of local blob sink client ([#13025](#13025)) ([ba8d654](ba8d654)) * **avm:** semicolons are hard ([#12999](#12999)) ([8871c83](8871c83)) * bootstrap network and sponsored fpc devnet ([#13044](#13044)) ([8a47d8b](8a47d8b)) * Bump tsc target ([#13052](#13052)) ([985e83b](985e83b)) * cycle_group fuzzer ([#12921](#12921)) ([69f426e](69f426e)) * **docs:** Fix import errors in aztec.js tutorial ([#12969](#12969)) ([856208a](856208a)) * **docs:** Load token artifact from the compiled source in the sample dapp tutorial ([#12802](#12802)) ([0838084](0838084)), closes [#12810](#12810) * **docs:** Update sponsored fpc docs to use 82.2 syntax ([#13054](#13054)) ([e5d425b](e5d425b)) * **e2e:** p2p ([#13002](#13002)) ([1ece539](1ece539)) * extend e2e 2 pxes timeout. strip color codes for error_regex. ([73820e4](73820e4)) * flake ([6cc9e81](6cc9e81)) * fuzzer on staking asset handler constructor test ([#13101](#13101)) ([d936285](d936285)) * invalid getCommittee function ([#13072](#13072)) ([327341f](327341f)) * mac publish should use clang 18 like x-compiler, and use it ([#12983](#12983)) ([7b83c45](7b83c45)) * make circuit parsing deterministic ([#11772](#11772)) ([76ef873](76ef873)) * parse away trailing slash from consensus host ([#12577](#12577)) ([6701806](6701806)) * prerelease versions should be pushed to install.aztec.network ([#13086](#13086)) ([c4e6039](c4e6039)) * smoke ([#13060](#13060)) ([7756b15](7756b15)) * some flake additions ([58638f1](58638f1)) * sponsored fpc arg parsed correctly ([#12976](#12976)) ([#12977](#12977)) ([a85f530](a85f530)) * starting the sandbox with no pxe should still deploy initial test accounts ([#13047](#13047)) ([d92d895](d92d895)) * Syntax error when running tests via jest after tsc build ([#13051](#13051)) ([f972db9](f972db9)) * Use the correct image in aztec start ([#13058](#13058)) ([06285cd](06285cd)) * yolo fix ([91e2f4b](91e2f4b)) * yolo fix nightly ([b3b3259](b3b3259)) * yolo fix obvious thing to track fails. ([2fee630](2fee630)) * yolo flakes ([e3b030a](e3b030a)) * yolo set -x ([bfd3205](bfd3205)) * yolo we suspect the halt is making tests fail that would have passed ([04e3fa2](04e3fa2)) ### Miscellaneous * `getIndexedTaggingSecretAsSender` oracle cleanup ([#13015](#13015)) ([8e71e55](8e71e55)) * Add a script to generate cpp files for AVM2 ([#13091](#13091)) ([7bb43a9](7bb43a9)) * add default native proving for cli wallet ([#12855](#12855)) ([c0f773c](c0f773c)) * add default native proving for cli wallet retry ([#13028](#13028)) ([b2f4785](b2f4785)) * Alpha testnet into master ([#13033](#13033)) ([d98fdbd](d98fdbd)) * AVM TS - move tag validation outside of instruction constructors ([#13038](#13038)) ([45548ab](45548ab)), closes [#12934](#12934) * **avm:** final codegen nuking ([#13089](#13089)) ([9c82f3f](9c82f3f)) * **avm:** remove codegen (all but flavor) ([#13079](#13079)) ([e1f2bdd](e1f2bdd)) * **bb:** minor acir buf C++ improvements ([#13042](#13042)) ([1ebd044](1ebd044)) * boxes dep cleanup ([#12979](#12979)) ([6540b7c](6540b7c)) * **ci:** less catch all e2e_p2p flakes ([#12737](#12737)) ([2134634](2134634)) * comprehensive cleanup of translator flavor and use inheritance properly in flavors ([#13041](#13041)) ([dc5f78f](dc5f78f)) * compress storage footprint ([#12871](#12871)) ([58c110f](58c110f)) * display warning when installing bb versions < 0.82.0 ([#13027](#13027)) ([7247fe7](7247fe7)) * **docs:** Update docs on fees and various other updates ([#12929](#12929)) ([1dec907](1dec907)) * dump dmesg/net/cpu/mem usage at end of ci run ([#12967](#12967)) ([8877792](8877792)) * fix governance util issue ([#13043](#13043)) ([d768d26](d768d26)) * redundant if in affine from projective constructor ([#13045](#13045)) ([3a7ba2d](3a7ba2d)) * remove addition of dummy ops in mock circuit producer ([#13003](#13003)) ([a64d1dc](a64d1dc)) * remove dummy ops in decider pk ([#13049](#13049)) ([da6d021](da6d021)) * replace relative paths to noir-protocol-circuits ([e1b88f6](e1b88f6)) * replace relative paths to noir-protocol-circuits ([849b4b0](849b4b0)) * replace relative paths to noir-protocol-circuits ([18a02d6](18a02d6)) * Revert "chore: add default native proving for cli wallet ([#12855](#12855))" ([#13013](#13013)) ([98e2576](98e2576)) * Speed up and deflake sentinel test ([#13078](#13078)) ([27f1eca](27f1eca)) * **testnet:** making consensus host mandatory input ([#12716](#12716)) ([d47c74a](d47c74a)) * towards no more mock op_queues ([#12984](#12984)) ([fefffa7](fefffa7)) * update bb version for noir 1.0.0-beta.0+ ([#13026](#13026)) ([dd68074](dd68074)) * update CODEOWNERS to reflect new sync method ([#12998](#12998)) ([a3d1915](a3d1915)) ### Documentation * Add fees to cli reference ([#12884](#12884)) ([4a0fd58](4a0fd58)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan mentioned this pull request Mar 22, 2025

feat: LogEncryption trait #12942

Merged

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from e840fac to e2007fb Compare March 22, 2025 02:18

benesjan commented Mar 22, 2025

View reviewed changes

noir-projects/aztec-nr/aztec/src/encrypted_logs/log_assembly_strategies/default_aes128/note.nr Show resolved Hide resolved

benesjan marked this pull request as ready for review March 22, 2025 02:52

benesjan mentioned this pull request Mar 22, 2025

feat!: processing events in Aztec.nr #12957

Merged

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from 91ef7b5 to 81e2e8f Compare March 24, 2025 20:54

benesjan force-pushed the 03-21-feat_logencryption_trait branch from c7abf5b to 82b64f4 Compare March 24, 2025 20:54

benesjan mentioned this pull request Mar 24, 2025

feat: purge of log decryption in TS #12992

Merged

benesjan requested a review from nventuro March 24, 2025 22:35

nventuro approved these changes Mar 25, 2025

View reviewed changes

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from 81e2e8f to d6890de Compare March 25, 2025 20:46

benesjan force-pushed the 03-21-feat_logencryption_trait branch from 07d0922 to ca370cc Compare March 25, 2025 20:46

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from d6890de to 223a998 Compare March 25, 2025 21:00

benesjan marked this pull request as draft March 25, 2025 21:04

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from 314cf2f to eddb092 Compare March 25, 2025 21:10

benesjan force-pushed the 03-21-feat_logencryption_trait branch from ffb9962 to 353caf7 Compare March 25, 2025 21:10

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from eddb092 to 6569bda Compare March 25, 2025 21:16

benesjan marked this pull request as ready for review March 25, 2025 22:17

benesjan marked this pull request as draft March 26, 2025 01:07

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch 2 times, most recently from c7a7413 to d7257f9 Compare March 26, 2025 02:11

benesjan marked this pull request as ready for review March 26, 2025 02:15

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from d7257f9 to 02d9275 Compare March 26, 2025 02:22

benesjan mentioned this pull request Mar 26, 2025

fix: tagging bug #13061

Merged

nventuro approved these changes Mar 27, 2025

View reviewed changes

Base automatically changed from 03-21-feat_logencryption_trait to master March 27, 2025 02:00

benesjan added 3 commits March 27, 2025 02:01

feat: 64 bit log type id, 64 bit log metadata

911dd38

making it less ugly

4d7c837

WIP

07f94a7

benesjan and others added 11 commits March 27, 2025 02:01

fixes

be737f4

Update noir-projects/aztec-nr/aztec/src/discovery/private_logs.nr

7a8ea2b

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

Update noir-projects/aztec-nr/aztec/src/discovery/private_logs.nr

10d9407

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

Update noir-projects/aztec-nr/aztec/src/encrypted_logs/log_type.nr

b1e9229

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

fix

9100c17

stale comment update

c86959b

subvec in spellcheck

b480842

u64s_packing utils

4442837

swapping metadata and log type id

fb445a3

making u64s packing metadata specific

470b5ca

roundtrip_metadata fuzz test

4724c0c

benesjan force-pushed the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch from 64b40d8 to 4724c0c Compare March 27, 2025 02:01

benesjan merged commit 20d734a into master Mar 27, 2025
8 checks passed

benesjan deleted the 03-22-feat_64_bit_log_type_id_64_bit_log_metadata branch March 27, 2025 02:32

AztecBot mentioned this pull request Mar 27, 2025

chore(master): release 0.82.3 #12980

Merged

DanielKotov pushed a commit that referenced this pull request Mar 27, 2025

feat: 64 bit log type id, 64 bit log metadata (#12956)

3254162

DanielKotov pushed a commit that referenced this pull request Mar 27, 2025

feat: 64 bit log type id, 64 bit log metadata (#12956)

07d261f

benesjan mentioned this pull request Mar 27, 2025

refactor: minor tagging API improvement #13092

Merged

Conversation

benesjan commented Mar 22, 2025

Uh oh!

benesjan commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nventuro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benesjan commented Mar 22, 2025 •

edited

Loading