Conversation
sklppy88
changed the title
sklppy88
force-pushed
the
ek/fix/12466/remove-hard-coding-of-constructor-for-account-contract
branch
from
15c43aa to
d33a42d
Compare
sklppy88
force-pushed
the
ek/fix/12466/remove-hard-coding-of-constructor-for-account-contract
branch
2 times, most recently
from
f02a480 to
13d1c1a
Compare
Contributor
|
Good improvement, but why an array instead of an object with |
sklppy88
force-pushed
the
ek/fix/12466/remove-hard-coding-of-constructor-for-account-contract
branch
from
13d1c1a to
295f4f0
Compare
Contributor
Author
I was trying to make the tuple work, but yeah you're right. I don't think it makes any real sense compared to the alternative of an object here... I have modified it to make it more clear according to your suggestion. Thank you ! |
Thunkar
approved these changes
Mar 13, 2025
sklppy88
deleted the
ek/fix/12466/remove-hard-coding-of-constructor-for-account-contract
branch
TomAFrench
added a commit
that referenced
this pull request
Mar 14, 2025
* master: fix: filter for empty attestations when pulling from block (#12740) feat: one-way noir sync (#12592) feat(avm): Address derivation gadget (#12721) chore(ci): add workflow dispatch to masternet (#12739) feat: add default accounts (#12734) feat: gas reports and snapshots (#12724) fix(avm): fix vm1 fake proof size (#12733) feat(bb): extend_edges optimization for zero values past end_index (#12703) fix: remove hard coding of constructor for account manager (#12678) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: verify_honk_proof inputs generation in bootstrap (#12457) fix: Patches to cycle_group and cycle_group fuzzer (#12385)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12466