fix: verify_honk_proof inputs generation in bootstrap#12457
Conversation
barretenberg/acir_tests/bootstrap.sh
Outdated
| cd ../.. | ||
|
|
||
|
|
||
| # $bb OLD_API write_recursion_inputs_ultra_honk -b ./target/program.json -o ../verify_honk_proof --recursive |
There was a problem hiding this comment.
can delete these flows
barretenberg/acir_tests/bootstrap.sh
Outdated
| trap "rm -rf $outdir" EXIT | ||
| local key_hash="0x0000000000000000000000000000000000000000000000000000000000000000" | ||
|
|
||
| local prove_uh_cmd="$bb prove --scheme ultra_honk --init_kzg_accumulator --output_format fields --write_vk -o $outdir -b ./target/program.json -w ./target/witness.gz" |
There was a problem hiding this comment.
this as a whole is honestly a little more complicated than I would've liked... unclear if this that much better than the write_recursion_inputs_ultra_honk flows
There was a problem hiding this comment.
its probably easier to have all the logic here though instead of having to modify both bootstrap and cpp files, even if this is quite annoying logic to handle in bash/jq
ludamad
left a comment
ludamad
left a comment
There was a problem hiding this comment.
approving with request to clean up this jq logic. It needs some helpers to be readable. Ideally a helper for generating public inputs, with comments to how, and another for generating proof etc.
charlielye
left a comment
charlielye
left a comment
There was a problem hiding this comment.
IIUC, what I would have done is just compile assert_statement, then generate the proof inputs, then just compile everything.
But this works too.
|
Good with me |
* master: fix: filter for empty attestations when pulling from block (#12740) feat: one-way noir sync (#12592) feat(avm): Address derivation gadget (#12721) chore(ci): add workflow dispatch to masternet (#12739) feat: add default accounts (#12734) feat: gas reports and snapshots (#12724) fix(avm): fix vm1 fake proof size (#12733) feat(bb): extend_edges optimization for zero values past end_index (#12703) fix: remove hard coding of constructor for account manager (#12678) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: verify_honk_proof inputs generation in bootstrap (#12457) fix: Patches to cycle_group and cycle_group fuzzer (#12385)
3 participants
Closes AztecProtocol/barretenberg#1279, fixing the acir test input generation workflow.
Closes AztecProtocol/barretenberg#1253, deprecating the write_recursion_inputs_ultra_honk flows.
Closes AztecProtocol/barretenberg#1285, adding support for generating double_verify_honk_proof inputs.
Reorders compilation so that we compile verify_honk_proof and verify_rollup_honk_proof only after compiling the rest of the programs and running write_recursion_inputs_honk to generate new Prover.tomls.
Also adds input generation for double_verify_honk_proof. This style of input generation is an easier flow for future updating.