chore(archiver): l2proven number not required#12424
Merged
Conversation
LHerskind
approved these changes
Mar 3, 2025
| archiveForLocalPendingBlockNumber, | ||
| provenEpochNumber, | ||
| ] = await this.rollup.read.status([localPendingBlockNumber], { blockNumber: currentL1BlockNumber }); | ||
| const [provenBlockNumber, provenArchive, pendingBlockNumber, pendingArchive, archiveForLocalPendingBlockNumber] = |
Contributor
There was a problem hiding this comment.
Not necessarily for this pr, just got thinking, why are we using the viem contract directly in the archiver when we are using a RollupContract a bunch elsewhere (know there are a lot of both things around and about). Probably something we should look into at some point.
| localProvenEpochNumber !== Number(provenEpochNumber) || | ||
| localProvenBlockNumber !== Number(provenBlockNumber) | ||
| ) { | ||
| const localProvenBlockNumber = await this.store.getProvenL2BlockNumber(); |
Contributor
There was a problem hiding this comment.
Seems like this is only used this once, so don't seem necessary to put it in a const 🤷 Fine to keep though.
TomAFrench
added a commit
that referenced
this pull request
Mar 4, 2025
* master: (229 commits) feat: Sync from noir (#12315) fix: Only use debug logging for ENR mismatch (#12439) yolo upadate test pattern owners for kind tests fix: Don't exit on error when querying secret (#12438) fix: consolidate sepoliaETH job condition (#12437) chore: add `yq` to `bootstrap.sh check` (#12436) fix: ignition-testnet values & bot count (#12433) chore(archiver): l2proven number not required (#12424) chore: PXE oracle refactor (#12410) fix: txes handle sigint and sigterm, use dump fail to see any txe errors (#12427) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore: set enrs and contract addresses in ignition-testnet (#12417) chore: reenable public teardown in orchestrator test (#12428) feat: add wasm mode for profiler (#12407) feat: contract instance/class cache for current tx - ensure that later txs in block cannot wipe out contracts created earlier (#12261) chore: pull out formatter changes from sync (#12426) chore: calculate available memory for noir-projects/bootstrap.sh memsuspend (#12419) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
After a discussion with @LHerskind, it appears that this is not required at all to work out if there have been reorgs, and it
is not used anywhere else.
The proven epoch is stored in the l1 contract, and the check in the archiver where it is used, is not required, as time is encoded
within the archive hash that is compared.
This pr just removes it