feat: contract instance/class cache for current tx - ensure that later txs in block cannot wipe out contracts created earlier

[dbanks12]

Ensures that contracts only get wiped out of the cache when they really should.

What's included

1. Separates the caches for ContractDataSourcePublicDB as follows:

   private blockCache = new TxContractCache();
   private currentTxNonRevertibleCache = new TxContractCache();
   private currentTxRevertibleCache = new TxContractCache();
   private bytecodeCommitmentCache = new Map<string, Fr>();
   

   • using a new little cache class TxContractCache.
2. Caches non-revertibles before public setup and revertibles before public app logic.
3. Pushes all new contracts to block-level cache for private-only txs.
4. Includes some progress towards ensuring that contracts can be called after deployment in same block (including public-processor and e2e tests)
5. Rearranged some things in simulator/src/public into subfolders
6. Created a new suite of deployment tests for public processor.

Issues

I discovered during this work, that if you run certain test-cases in deploy_method.test.ts on their own (without running earlier test cases, they fail as follows (happens on master):

This holds true for the new test. This might mean that contracts cannot be properly called after deployment in the same block! More investigation is needed in another ticket/pr.

Also, I can run all of the deploy_method.test.ts tests locally and they pass, but in CI, the new one fails:

[dbanks12]

I copied this code only to realize that this 32 was wrong. Doesn't matter here because the bytecode is fake, but it mattered for real bytecode.

[spalladino]

LGTM! One question though: are the ContractsDataSourcePublicDB getters for classes and instances used from both public setup and public app? If so, should we disallow loading a contract class/instance created in a private revertible phase in the public setup? Otherwise, if the app logic reverts, the contract will never have been deployed, and public setup would be running on unpublished code. Does this make sense?

[MirandaWood]

LGTM 🚀

[MirandaWood]

This looks good! If it's easier/cleaner I can change tx.data.getNonEmptyContractClassLogsHashes() to a pair of fns like get(Non)RevertibleContractClassLogsHashes()? IIRC I added the original to make this code clearer, and have some cc log cleanup to do anyway (#12325). LMK!

[dbanks12]

I think that would help clean this up! Can be done after this PR though

[dbanks12]

LGTM! One question though: are the ContractsDataSourcePublicDB getters for classes and instances used from both public setup and public app? If so, should we disallow loading a contract class/instance created in a private revertible phase in the public setup? Otherwise, if the app logic reverts, the contract will never have been deployed, and public setup would be running on unpublished code. Does this make sense?

@spalladino good catch! I updated it so that we can add non-revertible contract infos separately from revertibles. PublicTxSimulator now adds only the non-revertibles during/before setup, and then adds revertibles during/before app logic.

Also note that before this PR, none of the contract classes/instances from a private-only TX were ever added to ContractsDataSourcePublicDB since we only ever called addNewContracts in PublicTxSimulator.