Skip to content

fix: don't early-out on test fails #12143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 2 commits into from
Feb 20, 2025
Merged

fix: don't early-out on test fails #12143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff7a53c
fix: don't early-out on test fails
ludamad Feb 20, 2025
63df137
Update parallelise
ludamad Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ci3/parallelise
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ NO_CD=1 source $(git rev-parse --show-toplevel)/ci3/source

cd $root
jobs=$(get_num_cpus_max ${1:-})
parallel_args="-j$jobs --memsuspend ${MEMSUSPEND:-64G} --line-buffer --joblog joblog.txt --halt now,fail=1"
parallel_args="-j$jobs --memsuspend ${MEMSUSPEND:-64G} --line-buffer --joblog joblog.txt"

echo "Starting test run with max $jobs jobs..."

Expand All @@ -22,7 +22,9 @@ if [ -t 1 ]; then
fi
set -e
else
denoise "parallel $parallel_args 'run_test_cmd {}'"
# TODO reinstate denoise once it can print out a log link early.
# denoise "parallel $parallel_args 'run_test_cmd {}'"
parallel $parallel_args 'run_test_cmd {}'
fi

slow_jobs=$(cat joblog.txt | \
Expand Down