Skip to content

feat: PIL relations modifications for bc decomposition#11935

Merged
jeanmon merged 10 commits intomasterfrom
jm/avm2-byte-decomposition
Feb 13, 2025
Merged

feat: PIL relations modifications for bc decomposition#11935
jeanmon merged 10 commits intomasterfrom
jm/avm2-byte-decomposition

Conversation

@jeanmon
Copy link
Contributor

@jeanmon jeanmon commented Feb 12, 2025 •
edited by fcarreiro
Loading 

----------------------------------------------------------------------
Benchmark                            Time             CPU   Iterations
----------------------------------------------------------------------
alu_acc_random                   0.126 us        0.126 us      5553823
bc_decomposition_acc_random       8.73 us         8.73 us        80583
bc_retrieval_acc_random          0.024 us        0.024 us     29187915
bitwise_acc_random                1.42 us         1.42 us       493026
ecc_acc_random                    2.59 us         2.59 us       269872
execution_acc_random             0.524 us        0.524 us      1339762
instr_fetching_acc_random        0.024 us        0.024 us     29288136
range_check_acc_random            2.67 us         2.67 us       262513
sha256_acc_random                 6.25 us         6.25 us       111991

@jeanmon jeanmon force-pushed the jm/avm2-byte-decomposition branch from e09cc53 to d8b65a7 Compare February 12, 2025 15:52
@jeanmon jeanmon marked this pull request as ready for review February 12, 2025 20:30
@jeanmon jeanmon force-pushed the jm/avm2-byte-decomposition branch 2 times, most recently from b4bc442 to 80737dc Compare February 13, 2025 10:11
IlyasRidhuan
IlyasRidhuan reviewed Feb 13, 2025
View reviewed changes
fcarreiro
fcarreiro reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@fcarreiro fcarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a VM2 PoV. Once you finish and Ilyas approves, I'm curious if you can run the benchmarks again to see the cost after the extra constraining.

@jeanmon jeanmon force-pushed the jm/avm2-byte-decomposition branch from 80737dc to 21fb996 Compare February 13, 2025 14:06
@jeanmon jeanmon force-pushed the jm/avm2-byte-decomposition branch from 21fb996 to 1bc03a1 Compare February 13, 2025 15:10
@jeanmon
Copy link
Contributor Author

jeanmon commented Feb 13, 2025 •
edited by fcarreiro
Loading

Looks good from a VM2 PoV. Once you finish and Ilyas approves, I'm curious if you can run the benchmarks again to see the cost after the extra constraining.

@fcarreiro

----------------------------------------------------------------------
Benchmark                            Time             CPU   Iterations
----------------------------------------------------------------------
alu_acc_random                   0.126 us        0.126 us      5553823
bc_decomposition_acc_random       8.73 us         8.73 us        80583
bc_retrieval_acc_random          0.024 us        0.024 us     29187915
bitwise_acc_random                1.42 us         1.42 us       493026
ecc_acc_random                    2.59 us         2.59 us       269872
execution_acc_random             0.524 us        0.524 us      1339762
instr_fetching_acc_random        0.024 us        0.024 us     29288136
range_check_acc_random            2.67 us         2.67 us       262513
sha256_acc_random                 6.25 us         6.25 us       111991

@jeanmon jeanmon merged commit 6c93058 into master Feb 13, 2025
53 checks passed
@jeanmon jeanmon deleted the jm/avm2-byte-decomposition branch February 13, 2025 16:35
@AztecBot AztecBot mentioned this pull request Feb 13, 2025
Merged
rahul-kothari pushed a commit that referenced this pull request Mar 5, 2025
@AztecBot
chore(master): Release 0.77.0 (#11985)
d041cbc 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.77.0</summary>

##
[0.77.0](aztec-package-v0.76.4...aztec-package-v0.77.0)
(2025-02-14)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.77.0</summary>

##
[0.77.0](barretenberg.js-v0.76.4...barretenberg.js-v0.77.0)
(2025-02-14)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.77.0</summary>

##
[0.77.0](aztec-packages-v0.76.4...aztec-packages-v0.77.0)
(2025-02-14)


### ⚠ BREAKING CHANGES

* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)

### Features

* PIL relations modifications for bc decomposition
([#11935](#11935))
([6c93058](6c93058))
* Poseidon2 in vm2
([#11597](#11597))
([2c199d8](2c199d8))
* Refactor `append_tx_effects_for_blob`
([#11805](#11805))
([e5a055b](e5a055b))


### Bug Fixes

* **docs:** Update token bridge diagram
([#11982](#11982))
([e5da9ed](e5da9ed))
* Let LSP read `noirfmt.toml` for formatting files
(noir-lang/noir#7355)
([4d35d2f](4d35d2f))
* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)
([4d35d2f](4d35d2f))
* Test more prover agents devnet
([#11990](#11990))
([f12be5f](f12be5f))


### Miscellaneous

* Avoid u128s in brillig memory
(noir-lang/noir#7363)
([4d35d2f](4d35d2f))
* **ci:** Downgrade 4epochs test to transfer test
([#11983](#11983))
([2340aab](2340aab))
* Explanations about skippable
([#11984](#11984))
([19589bc](19589bc))
* Op wires index from 0
([#11986](#11986))
([be1b563](be1b563))
* Prep for ci3
([8edee9e](8edee9e))
* Remove browser test
([3e570be](3e570be))
* Replace relative paths to noir-protocol-circuits
([b8ba716](b8ba716))
* Some polishing on the skippable document
([#11997](#11997))
([50e0a38](50e0a38))
* Update docs about integer overflows
(noir-lang/noir#7370)
([4d35d2f](4d35d2f))
</details>

<details><summary>barretenberg: 0.77.0</summary>

##
[0.77.0](barretenberg-v0.76.4...barretenberg-v0.77.0)
(2025-02-14)


### Features

* PIL relations modifications for bc decomposition
([#11935](#11935))
([6c93058](6c93058))
* Poseidon2 in vm2
([#11597](#11597))
([2c199d8](2c199d8))


### Miscellaneous

* Explanations about skippable
([#11984](#11984))
([19589bc](19589bc))
* Op wires index from 0
([#11986](#11986))
([be1b563](be1b563))
* Some polishing on the skippable document
([#11997](#11997))
([50e0a38](50e0a38))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Mar 6, 2025
@AztecBot
chore(master): Release 0.77.0 (#11985)
0653c46 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@aztec-package-v0.76.4...aztec-package-v0.77.0)
(2025-02-14)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@barretenberg.js-v0.76.4...barretenberg.js-v0.77.0)
(2025-02-14)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@aztec-packages-v0.76.4...aztec-packages-v0.77.0)
(2025-02-14)


### ⚠ BREAKING CHANGES

* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)

### Features

* PIL relations modifications for bc decomposition
([#11935](AztecProtocol/aztec-packages#11935))
([6c93058](AztecProtocol/aztec-packages@6c93058))
* Poseidon2 in vm2
([#11597](AztecProtocol/aztec-packages#11597))
([2c199d8](AztecProtocol/aztec-packages@2c199d8))
* Refactor `append_tx_effects_for_blob`
([#11805](AztecProtocol/aztec-packages#11805))
([e5a055b](AztecProtocol/aztec-packages@e5a055b))


### Bug Fixes

* **docs:** Update token bridge diagram
([#11982](AztecProtocol/aztec-packages#11982))
([e5da9ed](AztecProtocol/aztec-packages@e5da9ed))
* Let LSP read `noirfmt.toml` for formatting files
(noir-lang/noir#7355)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
* Test more prover agents devnet
([#11990](AztecProtocol/aztec-packages#11990))
([f12be5f](AztecProtocol/aztec-packages@f12be5f))


### Miscellaneous

* Avoid u128s in brillig memory
(noir-lang/noir#7363)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
* **ci:** Downgrade 4epochs test to transfer test
([#11983](AztecProtocol/aztec-packages#11983))
([2340aab](AztecProtocol/aztec-packages@2340aab))
* Explanations about skippable
([#11984](AztecProtocol/aztec-packages#11984))
([19589bc](AztecProtocol/aztec-packages@19589bc))
* Op wires index from 0
([#11986](AztecProtocol/aztec-packages#11986))
([be1b563](AztecProtocol/aztec-packages@be1b563))
* Prep for ci3
([8edee9e](AztecProtocol/aztec-packages@8edee9e))
* Remove browser test
([3e570be](AztecProtocol/aztec-packages@3e570be))
* Replace relative paths to noir-protocol-circuits
([b8ba716](AztecProtocol/aztec-packages@b8ba716))
* Some polishing on the skippable document
([#11997](AztecProtocol/aztec-packages#11997))
([50e0a38](AztecProtocol/aztec-packages@50e0a38))
* Update docs about integer overflows
(noir-lang/noir#7370)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
</details>

<details><summary>barretenberg: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@barretenberg-v0.76.4...barretenberg-v0.77.0)
(2025-02-14)


### Features

* PIL relations modifications for bc decomposition
([#11935](AztecProtocol/aztec-packages#11935))
([6c93058](AztecProtocol/aztec-packages@6c93058))
* Poseidon2 in vm2
([#11597](AztecProtocol/aztec-packages#11597))
([2c199d8](AztecProtocol/aztec-packages@2c199d8))


### Miscellaneous

* Explanations about skippable
([#11984](AztecProtocol/aztec-packages#11984))
([19589bc](AztecProtocol/aztec-packages@19589bc))
* Op wires index from 0
([#11986](AztecProtocol/aztec-packages#11986))
([be1b563](AztecProtocol/aztec-packages@be1b563))
* Some polishing on the skippable document
([#11997](AztecProtocol/aztec-packages#11997))
([50e0a38](AztecProtocol/aztec-packages@50e0a38))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcarreiro fcarreiro fcarreiro left review comments

@IlyasRidhuan IlyasRidhuan IlyasRidhuan approved these changes

@Maddiaa0 Maddiaa0 Awaiting requested review from Maddiaa0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeanmon @fcarreiro @IlyasRidhuan