Skip to content

feat: refactor append_tx_effects_for_blob#11805

Merged
MirandaWood merged 6 commits intomasterfrom
mw/refactor-blob-append
Feb 13, 2025
Merged

feat: refactor append_tx_effects_for_blob#11805
MirandaWood merged 6 commits intomasterfrom
mw/refactor-blob-append

Conversation

@MirandaWood
Copy link
Copy Markdown
Contributor

@MirandaWood MirandaWood commented Feb 7, 2025 •
edited
Loading

Refactors the append_tx_effects_for_blob function for #11058:

  • Removes expensive public data update gathering function
  • Combines the two get_effects functions into one to avoid doubling code

Should probably be merged after #11686, since that would be easier to merge into this PR rather than vice versa.

@MirandaWood MirandaWood marked this pull request as ready for review February 11, 2025 10:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

Changes to circuit sizes

Generated at commit: 6b66a9704202c5396c1ab8f4e1b95a51879c88d7, compared to commit: 438c905e710b54cc194da9be2da561c9a8c27c28

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private -2 ✅ -0.00% -2 ✅ -0.00%
rollup_base_public -22,155 ✅ -25.73% -75,073 ✅ -6.42%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private 137,828 (-2) -0.00% 1,637,357 (-2) -0.00%
rollup_base_public 63,937 (-22,155) -25.73% 1,094,488 (-75,073) -6.42%

@MirandaWood MirandaWood self-assigned this Feb 11, 2025
TomAFrench
TomAFrench approved these changes Feb 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this harms readability more than it helps tbh. I would prefer to just remove get_all_update_requests_for_tx_effects and avoid the other changes the but I'm gonna defer to circuits team on this as it's not my codebase.

@MirandaWood
Copy link
Copy Markdown
Contributor Author

MirandaWood commented Feb 13, 2025

I think this harms readability more than it helps tbh. I would prefer to just remove get_all_update_requests_for_tx_effects and avoid the other changes the but I'm gonna defer to circuits team on this as it's not my codebase.

Ah ok, I probably misunderstood the linked issue. I assumed 'repeated code' was also referring to the main fn and helper having essentially the same logic, but with either a check or assign. I can remove this, no worries! Will also get a review from the team

@github-actions

This comment was marked as outdated.

Sign in to view
@MirandaWood
Copy link
Copy Markdown
Contributor Author

MirandaWood commented Feb 13, 2025

I think this harms readability more than it helps tbh. I would prefer to just remove get_all_update_requests_for_tx_effects and avoid the other changes the but I'm gonna defer to circuits team on this as it's not my codebase.

Just FYI have reverted the other changes, lmk on the issue if anything else should be done to this function!

@MirandaWood MirandaWood merged commit e5a055b into master Feb 13, 2025
52 checks passed
@MirandaWood MirandaWood deleted the mw/refactor-blob-append branch February 13, 2025 16:43
@AztecBot AztecBot mentioned this pull request Feb 13, 2025
Merged
rahul-kothari pushed a commit that referenced this pull request Mar 5, 2025
@AztecBot
chore(master): Release 0.77.0 (#11985)
d041cbc 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.77.0</summary>

##
[0.77.0](aztec-package-v0.76.4...aztec-package-v0.77.0)
(2025-02-14)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.77.0</summary>

##
[0.77.0](barretenberg.js-v0.76.4...barretenberg.js-v0.77.0)
(2025-02-14)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.77.0</summary>

##
[0.77.0](aztec-packages-v0.76.4...aztec-packages-v0.77.0)
(2025-02-14)


### ⚠ BREAKING CHANGES

* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)

### Features

* PIL relations modifications for bc decomposition
([#11935](#11935))
([6c93058](6c93058))
* Poseidon2 in vm2
([#11597](#11597))
([2c199d8](2c199d8))
* Refactor `append_tx_effects_for_blob`
([#11805](#11805))
([e5a055b](e5a055b))


### Bug Fixes

* **docs:** Update token bridge diagram
([#11982](#11982))
([e5da9ed](e5da9ed))
* Let LSP read `noirfmt.toml` for formatting files
(noir-lang/noir#7355)
([4d35d2f](4d35d2f))
* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)
([4d35d2f](4d35d2f))
* Test more prover agents devnet
([#11990](#11990))
([f12be5f](f12be5f))


### Miscellaneous

* Avoid u128s in brillig memory
(noir-lang/noir#7363)
([4d35d2f](4d35d2f))
* **ci:** Downgrade 4epochs test to transfer test
([#11983](#11983))
([2340aab](2340aab))
* Explanations about skippable
([#11984](#11984))
([19589bc](19589bc))
* Op wires index from 0
([#11986](#11986))
([be1b563](be1b563))
* Prep for ci3
([8edee9e](8edee9e))
* Remove browser test
([3e570be](3e570be))
* Replace relative paths to noir-protocol-circuits
([b8ba716](b8ba716))
* Some polishing on the skippable document
([#11997](#11997))
([50e0a38](50e0a38))
* Update docs about integer overflows
(noir-lang/noir#7370)
([4d35d2f](4d35d2f))
</details>

<details><summary>barretenberg: 0.77.0</summary>

##
[0.77.0](barretenberg-v0.76.4...barretenberg-v0.77.0)
(2025-02-14)


### Features

* PIL relations modifications for bc decomposition
([#11935](#11935))
([6c93058](6c93058))
* Poseidon2 in vm2
([#11597](#11597))
([2c199d8](2c199d8))


### Miscellaneous

* Explanations about skippable
([#11984](#11984))
([19589bc](19589bc))
* Op wires index from 0
([#11986](#11986))
([be1b563](be1b563))
* Some polishing on the skippable document
([#11997](#11997))
([50e0a38](50e0a38))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Mar 6, 2025
@AztecBot
chore(master): Release 0.77.0 (#11985)
0653c46 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@aztec-package-v0.76.4...aztec-package-v0.77.0)
(2025-02-14)


### Miscellaneous

* **aztec-package:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg.js: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@barretenberg.js-v0.76.4...barretenberg.js-v0.77.0)
(2025-02-14)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@aztec-packages-v0.76.4...aztec-packages-v0.77.0)
(2025-02-14)


### ⚠ BREAKING CHANGES

* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)

### Features

* PIL relations modifications for bc decomposition
([#11935](AztecProtocol/aztec-packages#11935))
([6c93058](AztecProtocol/aztec-packages@6c93058))
* Poseidon2 in vm2
([#11597](AztecProtocol/aztec-packages#11597))
([2c199d8](AztecProtocol/aztec-packages@2c199d8))
* Refactor `append_tx_effects_for_blob`
([#11805](AztecProtocol/aztec-packages#11805))
([e5a055b](AztecProtocol/aztec-packages@e5a055b))


### Bug Fixes

* **docs:** Update token bridge diagram
([#11982](AztecProtocol/aztec-packages#11982))
([e5da9ed](AztecProtocol/aztec-packages@e5da9ed))
* Let LSP read `noirfmt.toml` for formatting files
(noir-lang/noir#7355)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
* Only decrement the counter of an array if its address has not changed
(noir-lang/noir#7297)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
* Test more prover agents devnet
([#11990](AztecProtocol/aztec-packages#11990))
([f12be5f](AztecProtocol/aztec-packages@f12be5f))


### Miscellaneous

* Avoid u128s in brillig memory
(noir-lang/noir#7363)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
* **ci:** Downgrade 4epochs test to transfer test
([#11983](AztecProtocol/aztec-packages#11983))
([2340aab](AztecProtocol/aztec-packages@2340aab))
* Explanations about skippable
([#11984](AztecProtocol/aztec-packages#11984))
([19589bc](AztecProtocol/aztec-packages@19589bc))
* Op wires index from 0
([#11986](AztecProtocol/aztec-packages#11986))
([be1b563](AztecProtocol/aztec-packages@be1b563))
* Prep for ci3
([8edee9e](AztecProtocol/aztec-packages@8edee9e))
* Remove browser test
([3e570be](AztecProtocol/aztec-packages@3e570be))
* Replace relative paths to noir-protocol-circuits
([b8ba716](AztecProtocol/aztec-packages@b8ba716))
* Some polishing on the skippable document
([#11997](AztecProtocol/aztec-packages#11997))
([50e0a38](AztecProtocol/aztec-packages@50e0a38))
* Update docs about integer overflows
(noir-lang/noir#7370)
([4d35d2f](AztecProtocol/aztec-packages@4d35d2f))
</details>

<details><summary>barretenberg: 0.77.0</summary>

##
[0.77.0](AztecProtocol/aztec-packages@barretenberg-v0.76.4...barretenberg-v0.77.0)
(2025-02-14)


### Features

* PIL relations modifications for bc decomposition
([#11935](AztecProtocol/aztec-packages#11935))
([6c93058](AztecProtocol/aztec-packages@6c93058))
* Poseidon2 in vm2
([#11597](AztecProtocol/aztec-packages#11597))
([2c199d8](AztecProtocol/aztec-packages@2c199d8))


### Miscellaneous

* Explanations about skippable
([#11984](AztecProtocol/aztec-packages#11984))
([19589bc](AztecProtocol/aztec-packages@19589bc))
* Op wires index from 0
([#11986](AztecProtocol/aztec-packages#11986))
([be1b563](AztecProtocol/aztec-packages@be1b563))
* Some polishing on the skippable document
([#11997](AztecProtocol/aztec-packages#11997))
([50e0a38](AztecProtocol/aztec-packages@50e0a38))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees

@MirandaWood MirandaWood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MirandaWood @TomAFrench