Dependencies: Replace classnames with clsx - v2 #91408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
Framework
[Status] Needs Review
tyxla
requested review from
aneeshd16 and
chad1008
and removed request for
a team
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~488 bytes removed 📉 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~4584 bytes removed 📉 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1924 bytes removed 📉 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
DaniGuardiola
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
LGTM! Due to the large amount of changes, and to GitHub being annoying and not loading diffs past certain amount of files, I couldn't review every single file properly. I did review every package.json file and most of the ones that GitHub did load.
I did look for more instances of the cx name, you'll find comments on them.
| @@ -7,7 +7,7 @@ import { useMediaQuery } from '@wordpress/compose'; | |||
| import { useDispatch, useSelect } from '@wordpress/data'; | |||
| import { useCallback, useEffect, useState } from '@wordpress/element'; | |||
| import { registerPlugin } from '@wordpress/plugins'; | |||
| import cx from 'classnames'; | |||
| import cx from 'clsx'; | |||
There was a problem hiding this comment.
Can we rename to clsx for consistency?
| @@ -1,7 +1,7 @@ | |||
| import config from '@automattic/calypso-config'; | |||
| import { Button, Gridicon } from '@automattic/components'; | |||
| import styled from '@emotion/styled'; | |||
| import cx from 'classnames'; | |||
| import cx from 'clsx'; | |||
There was a problem hiding this comment.
Same as other comment. We could rename to clsx for consistency.
| @@ -2,7 +2,7 @@ | |||
| import './styles.scss'; | |||
| import { getDesignPreviewUrl } from '@automattic/design-picker'; | |||
| import { MShotsImage, MShotsOptions } from '@automattic/onboarding'; | |||
| import cx from 'classnames'; | |||
| import cx from 'clsx'; | |||
There was a problem hiding this comment.
Same as other comment. We could rename to clsx for consistency.
| @@ -2,7 +2,7 @@ | |||
| import { useFocusTrap } from '@automattic/tour-kit'; | |||
| import { __ } from '@wordpress/i18n'; | |||
| import { globe, Icon, chevronUp, chevronDown } from '@wordpress/icons'; | |||
| import cx from 'classnames'; | |||
| import cx from 'clsx'; | |||
There was a problem hiding this comment.
Same as other comment. We could rename to clsx for consistency.
| @@ -1,5 +1,5 @@ | |||
| import { __ } from '@wordpress/i18n'; | |||
| import cx from 'classnames'; | |||
| import cx from 'clsx'; | |||
There was a problem hiding this comment.
Same as other comment. We could rename to clsx for consistency.
|
Thanks @DaniGuardiola 🙌 I'll follow-up with the rename in another PR - this PR is already huge as it is. |
github-actions
bot
removed
the
[Status] Needs Review
|
@DaniGuardiola #91413 is a follow-up PR to address your feedback from above. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR replaces
classnameswithclsxacross Calypso, which is a faster and lighter alternative. (v1 was #89843 but it was quite stale).@DaniGuardiola introduced it in Gutenberg in WordPress/gutenberg#61138 recently.
We can now replace it since we updated to the latest
@wordpresspackages in #91366.Testing Instructions