Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monorepo tooling: replace classnames with clsx #37695

Closed
jeherve opened this issue Jun 4, 2024 · 0 comments · Fixed by #37708
Closed

Monorepo tooling: replace classnames with clsx #37695

jeherve opened this issue Jun 4, 2024 · 0 comments · Fixed by #37708
Assignees
@tbradsha
Labels
Build Epic Formerly "Primary Issue", or "Master Issue" [Pri] Normal [Type] Janitorial

Comments

@jeherve
Copy link
Member

jeherve commented Jun 4, 2024 •
edited
Loading

Let's aim to replace classnames with clsx across the monorepo.

clsx is now used in Calypso (see Automattic/wp-calypso#91408), in Gutenberg (see WordPress/gutenberg#61138), and in @wordpress packages (related: #37669).

With that mind, it makes sense for Jetpack to make the switch as well, for better consistency.

Internal reference: p4TIVU-aYc-p2
@jeherve jeherve added [Type] Janitorial Epic Formerly "Primary Issue", or "Master Issue" [Pri] Normal Build labels Jun 4, 2024
@tbradsha tbradsha self-assigned this Jun 4, 2024
@tbradsha tbradsha mentioned this issue Jun 4, 2024
Merged
3 tasks
tbradsha added a commit that referenced this issue Jun 10, 2024
@tbradsha
Resolves #37695 - Use clsx instead of classnames (#37708)
40a8492 
* Add rule to disallow `classnames`

* Initial pass

* `classnames/dedupe` → `@wordpress/token-list`

* Add changelog

* Use valid changelog types

* Remove file from eslint exclusions

* Change post-rebase use of classnames

* More changelog format compliance fixes

* Bump versions
dilirity pushed a commit that referenced this issue Jun 11, 2024
@tbradsha @dilirity
Resolves #37695 - Use clsx instead of classnames (#37708)
9a3df1d 
* Add rule to disallow `classnames`

* Initial pass

* `classnames/dedupe` → `@wordpress/token-list`

* Add changelog

* Use valid changelog types

* Remove file from eslint exclusions

* Change post-rebase use of classnames

* More changelog format compliance fixes

* Bump versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbradsha tbradsha

Labels
Build Epic Formerly "Primary Issue", or "Master Issue" [Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #37695 - Use clsx instead of classnames Automattic/jetpack
2 participants
@jeherve @tbradsha