Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes around CSS keyframe identifiers #6546

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Remove quotes around CSS keyframe identifiers #6546

merged 1 commit into from
Jul 8, 2016

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Jul 6, 2016

Fix for #5797.

This PR removes the quotes around some of the CSS keyframe animation names.

Testing
loading-dot-pulse
This animation is applied to the ellipsis at the end of the "Trashing Post..." message when moving a post to the trash.

pulse-light
This animation pulsates the title box briefly when opening a post, before the title is populated.

loading-fade
This animation applies a fade effect to the cards on the Themes page before the images load.

appear
When saving changes to My Profile, this animation fades in the "Settings saved successfully!" message.

This is not a complete list of the scenarios in which these animations are applied, but should suffice for testing purposes.

Test live: https://calypso.live/?branch=fix/keyframe-animation-names

@matticbot matticbot added OSS Citizen [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 6, 2016
@gwwar
Copy link
Contributor

gwwar commented Jul 8, 2016

Thanks for the fix @donnapep! I've verified that the animations are broken in some browsers like FF, and now work with this fix.

@gwwar gwwar merged commit 7d14601 into Automattic:master Jul 8, 2016
@gwwar gwwar removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants