Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper syntax for some @keyframe animations #5797

Closed
jeffgolenski opened this issue Jun 3, 2016 · 1 comment
Closed

Improper syntax for some @keyframe animations #5797

jeffgolenski opened this issue Jun 3, 2016 · 1 comment
Labels
Components [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeffgolenski
Copy link
Member

While working with @dereksmart in dops-components we ended up following a trail back to calypso and finding some @keyframe animations with improper syntax. My guess is that these aren't working at all due to the quotations, and are throwing some scss errors somewhere - I haven't tested it.

https://github.com/Automattic/wp-calypso/blob/master/assets/stylesheets/shared/_animation.scss#L231

Problem:
On lines 232, 241, 245, and 251, the @keyframes animation names are wrapped in quotes and shouldn't be. (unless there's some black magic occurring I'm not aware of)

Fix:
Remove quotes around keyframe animation names.

Visual:
screen shot 2016-06-03 at 4 04 12 pm

@jeffgolenski jeffgolenski added the [Type] Bug When a feature is broken and / or not performing as intended label Jun 3, 2016
@lancewillett
Copy link
Contributor

Fixed in 7d14601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants