Skip to content

Signup: pointing to the proper developer welcome page #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Signup: pointing to the proper developer welcome page #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/devdocs/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ var devdocs = {
title: 'Log In to start hacking',
line: 'Required to access the WordPress.com API',
action: 'Log In to WordPress.com',
actionURL: 'https://wordpress.com/wp-login.php?redirect_to=http%3A%2F%2Fcalypso.localhost%3A3000',
actionURL: 'https://wordpress.com/wp-login.php?redirect_to=http%3A%2F%2Fcalypso.localhost%3A3000/devdocs/welcome',
secondaryAction: 'Register',
secondaryActionURL: '/start/developer',
illustration: '/calypso/images/drake/drake-nosites.svg'
Expand Down
2 changes: 1 addition & 1 deletion client/signup/config/flows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ const flows = {

developer: {
steps: [ 'themes', 'site', 'user' ],
destination: '/me/next?welcome',
destination: '/devdocs/welcome',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we take any precautions in environments that don't have devdocs enabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with @scruffian and a signup flow only shows up when you link directly to the flow (i.e., via /start/developer) and that only gets linked to from devdocs/controller.js... which is only available in an environment with devdocs enabled. So I don't think any other checks are necessary at this point.

description: 'Signup flow for developers in developer environment',
lastModified: '2015-11-23'
}
Expand Down