Signup: pointing to the proper developer welcome page #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rralian
added
[Status] Needs Review
|
Login works great. |
| @@ -128,7 +128,7 @@ const flows = { | |||
|
|
|||
| developer: { | |||
| steps: [ 'themes', 'site', 'user' ], | |||
| destination: '/me/next?welcome', | |||
| destination: '/devdocs/welcome', | |||
There was a problem hiding this comment.
Should we take any precautions in environments that don't have devdocs enabled?
There was a problem hiding this comment.
I checked with @scruffian and a signup flow only shows up when you link directly to the flow (i.e., via /start/developer) and that only gets linked to from devdocs/controller.js... which is only available in an environment with devdocs enabled. So I don't think any other checks are necessary at this point.
|
Signup works great, too. |
|
Let’s do it :) |
nb
added
[Status] Ready to Merge
and removed
[Status] Needs Review
nb
added a commit
that referenced
this pull request
Nov 23, 2015
…ects Signup: point to the developer welcome page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signup/register work was done separate from the devdocs/welcome work, so we need to wire it up.
Testing
@nb could you give this a runthrough? Test both register and login and make sure it takes you to the proper /devdocs/start page.