Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Change cancel flow for non-refundable purchases #468

Merged
merged 6 commits into from
Nov 23, 2015
Merged

Purchases: Change cancel flow for non-refundable purchases #468

merged 6 commits into from
Nov 23, 2015

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 23, 2015

Fixes #276 .

Description

Cancel link & button show up when all those conditions are met:

  • purchase is after refund window
  • purchase is not included in a plan
  • purchase has auto-renew enabled

Tasks

  • Change flow
  • Update backend to reflect new flow (isCancelable flag)

Testing

Apply patch fdd0.

  1. Go to http://calypso.localhost:3000/purchases.
  2. Select purchase that can be cancelled and is after refund window.
  3. Navigate to Cancel Purchase page.
  4. When you click on the Cancel button, it should be disabled. When action is successful user should see purchases list and green notice confirming that action was done.

Review

  • Code review
  • QA review

@gziolo gziolo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 23, 2015
@gziolo gziolo self-assigned this Nov 23, 2015
@gziolo gziolo added this to the Purchases: v1 milestone Nov 23, 2015
@gziolo
Copy link
Member Author

gziolo commented Nov 23, 2015

List of created tasks based on feedback from @fabianapsimoes:

There are no issues reported that are caused by this PR.

@gziolo
Copy link
Member Author

gziolo commented Nov 23, 2015

Patch deployed r127255-wpcom.

@scruffian
Copy link
Member

LGTM 👍

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015
gziolo added a commit that referenced this pull request Nov 23, 2015
@gziolo
Merge pull request #468 from Automattic/update/change-cancel-purchase…
5dd3a82 
…-flow

Purchases: Change cancel flow for non-refundable purchases

Fixes #276.
@gziolo gziolo merged commit 5dd3a82 into master Nov 23, 2015
@gziolo gziolo deleted the update/change-cancel-purchase-flow branch November 23, 2015 09:23
This was referenced Apr 13, 2021
Open
Open
This was referenced Apr 27, 2021
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@mdno mdno mentioned this pull request Nov 5, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Nov 5, 2022
Open
@anarh anarh mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@mdno mdno mentioned this pull request Dec 25, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Dec 26, 2022
Open
@anarh anarh mentioned this pull request Dec 26, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Oct 1, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gziolo gziolo

Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gziolo @scruffian @fabianapsimoes