Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebPreview: fix placing in smaller viewports. #4051

Closed
wants to merge 1 commit into from

Conversation

mtias
Copy link
Member

@mtias mtias commented Mar 15, 2016

Fixes #568.

See #3901.

@mtias mtias added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Components labels Mar 15, 2016
@aduth
Copy link
Contributor

aduth commented Mar 16, 2016

Hmm 5f3d3dd (#3350)

@aduth
Copy link
Contributor

aduth commented Mar 16, 2016

I can't seem to reproduce this issue described at #568 on my own site.

@aduth
Copy link
Contributor

aduth commented Mar 16, 2016

For me, this regresses to the behavior fixed by #3350. 👎

image

@aduth aduth added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 16, 2016
@aduth
Copy link
Contributor

aduth commented Mar 16, 2016

It seems the behavior on iOS is different than my Chrome desktop browser with at shrunken viewports, as the latter case does appear to be resolved by these changes.

@mtias
Copy link
Member Author

mtias commented Mar 21, 2016

Mmm, that's annoying.

@rralian rralian modified the milestones: Plans Iteration 0, Plans: Upgrade Nudges Mar 21, 2016
@rralian rralian modified the milestones: Stark Iteration 0, Stark Iteration 1 Apr 7, 2016
@rralian rralian removed this from the Plans Iteration 1 milestone Apr 15, 2016
@mtias mtias closed this Apr 22, 2016
@mtias mtias deleted the fix/web-preview-placing-mobile branch April 22, 2016 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components [Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants