Components: Prevent web preview from being obscured by master bar #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Post/Page Editor
aduth
changed the title
aduth
changed the title
No it wasn't the intent. I think just happened as a byproduct of some refactoring of both z-indexes and masterbar. :) It's correct for the WebPreview to be below the masterbar as you did. :) Thanks for the patch! :D |
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
aduth
added a commit
that referenced
this pull request
Feb 17, 2016
…ured Components: Prevent web preview from being obscured by master bar
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3339
This pull request seeks to resolve an issue where the master bar would obscure the
<WebPreview />component at small viewports.Design Notes:
@mtias @folletto : Do you recall if the intent was for the Web Preview to be shown above the master bar? In which case, this may be a
z-indexissue.Testing instructions:
Due to the nature of the changes, this should not affect larger displays, but it may be worth verifying all the same.
Ensure that the preview in the post editor or theme preview is not obscured by the master bar.
/cc @ryanboren