Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Show disabled autoupdate info #304

Merged
merged 4 commits into from
Nov 25, 2015

Conversation

enejb
Copy link
Member

@enejb enejb commented Nov 20, 2015

Uses the info popup to display info as to why there autoupdates are disabled.

screen shot 2015-11-19 at 4 56 03 pm

screen shot 2015-11-19 at 4 55 53 pm

To test
Go to: Plugin listing for a single site.
http://calypso.localhost:3000/plugins/example.com

Go to: Plugin view
http://calypso.localhost:3000/plugins/jetpack

Go to: Plugin view for a single site.
http://calypso.localhost:3000/plugins/jetpack/example.com

Notice the plugin autoupdates disabled info bubbles.

If your doesn't able to autoupdate
add the following to your wp-config.php

 define( 'FS_METHOD', 'ssh2' );
define( 'DISALLOW_FILE_EDIT', true );
 define( 'DISALLOW_FILE_MODS',true );
 define( 'WP_AUTO_UPDATE_CORE', false );
 define( 'AUTOMATIC_UPDATER_DISABLED', true );

and toggle the jetpack connection ( disconnect and connect )

@enejb enejb added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Jetpack Plugins labels Nov 20, 2015
@enejb
Copy link
Member Author

enejb commented Nov 20, 2015

@johnHackworth
Copy link
Contributor

OOOOOOOH!!!!!!!!!

This is awesomtastic!!!

@beaulebens
Copy link
Member

So much better with these in place! Love it.

@rickybanister
Copy link

I just pushed a small css fix to perfectly center the info icon within the space of the toggles and removed color rules that weren't working—I'm happy to just let it use the default colors from the component.

LGTM design-wise, just waiting for that fix to the js that toggles on and off the is-active class when you click/tap/hover the label.

@rickybanister rickybanister added [Status] Needs Author Reply and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2015
popoverName: React.PropTypes.string
popoverName: React.PropTypes.string,
isVisible: React.PropTypes.bool,
toggle: React.PropTypes.func
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's a good decision add this complexity to InfoPopover. I'm afraid that you if need handle the popover state from the parent component maybe you should use directly Popover and the Gridicon components.
cc @mtias

@enejb enejb force-pushed the update/plugins-show-disabled-autoupdate branch 2 times, most recently from 8d942ab to 47cdbc3 Compare November 20, 2015 23:23
<Gridicon icon="info-outline" size={ 18 } />
<Popover
isVisible={ this.state.showPopover }
context={ this.refs && this.refs.infoPopover }
ignoreContext={ this.props.ignoreContext }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to document this new prop (propType) and its purpose.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented in the readme :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we, please, add it to propTypes, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. I also updated the documentation of the Popover component"

@enejb enejb added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Nov 21, 2015
@enejb enejb force-pushed the update/plugins-show-disabled-autoupdate branch from 59f3fc1 to 5823d39 Compare November 22, 2015 19:42
@lezama
Copy link
Contributor

lezama commented Nov 23, 2015

I am getting this warnings on the browser:

image

@lezama lezama added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015

#### `ignoreContext`

The `ignoreContext` lets you specify an component that you want the when click on to be ignored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should re write this sentence :)

@enejb enejb force-pushed the update/plugins-show-disabled-autoupdate branch from 5823d39 to d96fceb Compare November 23, 2015 23:07
@enejb
Copy link
Member Author

enejb commented Nov 23, 2015

Rewrote the Readme and removed the react warnings. Thanks for bringing it up.

cc @johnHackworth and @lezama for another review.

@enejb enejb added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Nov 23, 2015

#### `ignoreContext`

The `ignoreContext` lets you specify an component that you want to be on the inside clickOutside context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "a component"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants