-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Show disabled autoupdate info #304
Conversation
OOOOOOOH!!!!!!!!! This is awesomtastic!!! |
So much better with these in place! Love it. |
I just pushed a small css fix to perfectly center the info icon within the space of the toggles and removed color rules that weren't working—I'm happy to just let it use the default colors from the component. LGTM design-wise, just waiting for that fix to the js that toggles on and off the |
popoverName: React.PropTypes.string | ||
popoverName: React.PropTypes.string, | ||
isVisible: React.PropTypes.bool, | ||
toggle: React.PropTypes.func |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's a good decision add this complexity to InfoPopover. I'm afraid that you if need handle the popover state from the parent component maybe you should use directly Popover
and the Gridicon
components.
cc @mtias
8d942ab
to
47cdbc3
Compare
<Gridicon icon="info-outline" size={ 18 } /> | ||
<Popover | ||
isVisible={ this.state.showPopover } | ||
context={ this.refs && this.refs.infoPopover } | ||
ignoreContext={ this.props.ignoreContext } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to document this new prop (propType
) and its purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented in the readme :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we, please, add it to propTypes
, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. I also updated the documentation of the Popover component"
59f3fc1
to
5823d39
Compare
|
||
#### `ignoreContext` | ||
|
||
The `ignoreContext` lets you specify an component that you want the when click on to be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should re write this sentence :)
5823d39
to
d96fceb
Compare
Rewrote the Readme and removed the react warnings. Thanks for bringing it up. cc @johnHackworth and @lezama for another review. |
|
||
#### `ignoreContext` | ||
|
||
The `ignoreContext` lets you specify an component that you want to be on the inside clickOutside context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be "a component"
Uses the info popup to display info as to why there autoupdates are disabled.
To test
Go to: Plugin listing for a single site.
http://calypso.localhost:3000/plugins/example.com
Go to: Plugin view
http://calypso.localhost:3000/plugins/jetpack
Go to: Plugin view for a single site.
http://calypso.localhost:3000/plugins/jetpack/example.com
Notice the plugin autoupdates disabled info bubbles.
If your doesn't able to autoupdate
add the following to your wp-config.php
and toggle the jetpack connection ( disconnect and connect )