Importer: Clean up section-import #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added
[Status] Needs Review
|
cc: @rralian |
dmsnell
force-pushed
the
update/importer/clean-up-section
branch
2 times, most recently
from
4450564
to
57a33b5
Compare
- Trim constants via ES6 module exports/imports - Merge render logic into `render()` - General cleanup fixup! Importer: Clean up section-import Remove Makefile because no tests exist
dmsnell
force-pushed
the
update/importer/clean-up-section
branch
from
57a33b5
to
813159d
Compare
|
I gave this a quick test drive and discovered no regressions. Would prefer to leave code review to others. Maybe @omarjackman or @jordwest could take a peek? |
| test: | ||
| @NODE_ENV=test NODE_PATH=$(NODE_PATH) $(MOCHA) --compilers $(COMPILERS) --reporter $(REPORTER) --ui $(UI) | ||
|
|
||
| .PHONY: test |
There was a problem hiding this comment.
Was this file intentionally deleted?
There was a problem hiding this comment.
it was left over from another PR where it should have been deleted. there are no tests left so the Makefile should go too
|
Gave it a test locally, also couldn't see any regressions. Code changes LGTM 🚢 |
jordwest
added
[Status] Ready to Merge
and removed
[Status] Needs Review
dmsnell
added a commit
that referenced
this pull request
Feb 3, 2016
…tion Importer: Clean up section-import
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
render()Testing This shouldn't change any functionality, so if you attempt an import and something borks out, it's broken. Otherwise it should be coding changes only.
The PR depends on #2949 and will shrink considerably once that's merged in.cc: @apeatling @rodrigoi @omarjackman @dllh @designsimply