Importer: Remove testing apparatus to flip through mock states #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added
[Status] Needs Review
dmsnell
force-pushed
the
remove/importer/mockup-selector
branch
from
15e941e
to
151eb79
Compare
|
Might need to rebase this to pick up the shrinkwrap file? |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Looks good! Rebase and it should pass tests and be ready to go. Nothing better than an all-red PR. :) |
|
Thanks @blowery |
dmsnell
force-pushed
the
remove/importer/mockup-selector
branch
from
151eb79
to
e43ec53
Compare
During the development of the importer we had a dropdown listing possible states for the UI. As the API starts to provide real data, testing can be accomplished with real data. Additionally, the mock states started to conflict with the real data anyway, so it is time this goes. Remove Makefile because no tests exist
dmsnell
force-pushed
the
remove/importer/mockup-selector
branch
from
e43ec53
to
574d61a
Compare
dmsnell
added a commit
that referenced
this pull request
Feb 1, 2016
Importer: Remove testing apparatus to flip through mock states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of the importer we had a dropdown listing
possible states for the UI. As the API starts to provide real data,
testing can be accomplished with real data.
Additionally, the mock states started to conflict with the real data
anyway, so it is time this goes.
Testing Navigate to My Sites > Settings > Import and the custom prop dropdown should be gone. There should be no errors. You should be able to send an import.
Before
After
cc: @apeatling @rodrigoi @omarjackman @dllh @designsimply