Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept comments argument in showSelectedPost #11606

Merged
merged 2 commits into from
Feb 27, 2017
Merged

Accept comments argument in showSelectedPost #11606

merged 2 commits into from
Feb 27, 2017

Commits on Feb 27, 2017

  1. Accept comments argument in showSelectedPost 

    Currently when clicking on a comment link in a stream we are passing a
`comments` attribute to `showSelectedPost` (via an object), however we
aren’t destructuring it and are doing nothing with it.

This commit adds `comments` to the arguments destructuring in
`showSelectedPost` and then passes the argument down to `showFullPost`,
which already supports and is smart enough to add `#comments` to the
URL.

As a result, now clicking on a the comments link in any card takes us to
the comments section of the post, not the title.

There are some limited tests, too.

Fixes #10951.
    @nb
    nb committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    dc18083 View commit details
    Browse the repository at this point in the history

  2. make SearchCardAdapter use correct arguments for showSelectedPost

    @samouri
    samouri committed Feb 27, 2017
    1 Configuration menu
    Copy the full SHA
    6f88c28 View commit details
    Browse the repository at this point in the history