Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: clicking "comment" on a card in any stream doesn't take you to the comments #10951

Closed
samouri opened this issue Jan 25, 2017 · 0 comments
Closed

Reader: clicking "comment" on a card in any stream doesn't take you to the comments #10951

samouri opened this issue Jan 25, 2017 · 0 comments
Labels
[Feature] Reader The reader site on Calypso. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended

Comments

@samouri
Copy link
Contributor

samouri commented Jan 25, 2017

When clicking the comments button on a card I expect to be taken directly to the commenting section
@samouri samouri added [Feature] Reader The reader site on Calypso. [Type] Bug When a feature is broken and / or not performing as intended labels Jan 25, 2017
@samouri samouri self-assigned this Jan 25, 2017
nb added a commit that referenced this issue Feb 27, 2017
@nb
Accept comments argument in showSelectedPost
dc18083 
Currently when clicking on a comment link in a stream we are passing a
`comments` attribute to `showSelectedPost` (via an object), however we
aren’t destructuring it and are doing nothing with it.

This commit adds `comments` to the arguments destructuring in
`showSelectedPost` and then passes the argument down to `showFullPost`,
which already supports and is smart enough to add `#comments` to the
URL.

As a result, now clicking on a the comments link in any card takes us to
the comments section of the post, not the title.

There are some limited tests, too.

Fixes #10951.
@nb nb mentioned this issue Feb 27, 2017
Merged
@samouri samouri added the [Pri] High Address as soon as possible after BLOCKER issues label Feb 27, 2017
@samouri samouri removed their assignment Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Reader The reader site on Calypso. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samouri