Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big Sky GF: Add AI Copy to big sky plans step #99127

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Big Sky GF: Add AI Copy to big sky plans step #99127

wants to merge 2 commits into from
+27 −0

Conversation

vykes-mac
Copy link
Contributor

@vykes-mac vykes-mac commented Jan 30, 2025 •
edited
Loading

Closes #99009

Proposed Changes

  • Add copy Unlimited AI Website Builder edits to big sky plans grid

image

image

Why are these changes being made?

  • Go to setup/onboarding goals first flow
  • Chose big sky on design choice screen
  • Continue to plans step and you should see the copy in the plans grid
  • Check the copy is also displayed on the checkout page

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vykes-mac vykes-mac self-assigned this Jan 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131577
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131577&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-131577&env=a8c-for-agencies

@vykes-mac vykes-mac added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. labels Jan 30, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~102 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-main        +371 B  (+0.0%)     +102 B  (+0.0%)
entry-login       +371 B  (+0.0%)     +102 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~105 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
write-flow                               +371 B  (+0.0%)     +105 B  (+0.0%)
update-design-flow                       +371 B  (+0.0%)     +105 B  (+0.0%)
site-setup-wg                            +371 B  (+0.1%)     +105 B  (+0.1%)
site-setup-flow                          +371 B  (+0.1%)     +105 B  (+0.1%)
plugin-bundle-flow                       +371 B  (+0.1%)     +105 B  (+0.1%)
onboarding-flow                          +371 B  (+0.2%)     +105 B  (+0.2%)
new-hosted-site-flow-user-included       +371 B  (+0.2%)     +105 B  (+0.2%)
new-hosted-site-flow                     +371 B  (+0.2%)     +105 B  (+0.2%)
link-in-bio-tld-flow                     +371 B  (+0.0%)     +105 B  (+0.0%)
import-hosted-site-flow                  +371 B  (+0.0%)     +105 B  (+0.0%)
import-flow                              +371 B  (+0.2%)     +105 B  (+0.2%)
hundred-year-plan                        +371 B  (+0.2%)     +105 B  (+0.2%)
hundred-year-domain                      +371 B  (+0.2%)     +105 B  (+0.2%)
copy-site-flow                           +371 B  (+0.0%)     +105 B  (+0.0%)
connect-domain                           +371 B  (+0.2%)     +105 B  (+0.2%)
build-flow                               +371 B  (+0.0%)     +105 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~105 bytes added 📈 [gzipped])

name                                        parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal       +371 B  (+0.0%)     +105 B  (+0.0%)
async-load-automattic-help-center-stepper        +371 B  (+0.0%)     +105 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vykes-mac
Copy link
Contributor Author

@p-jackson From the way the issue is worded it sounded like these copy should be rendered conditionally, is that the case?

@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • happy-blocks
  • help-center
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plan-step-copy on your sandbox.

@vykes-mac vykes-mac added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 30, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 30, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220117

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @vykes-mac for including a screenshot in the description! This is really helpful for our translators.

@p-jackson
Copy link
Member

@vykes-mac yeah this would be conditional on being in the onboarding flow, and have the onboarding/big-sky-before-plans feature flag (or this experiment #99096)

p-jackson
p-jackson requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@p-jackson p-jackson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, checking this now, I think these new featured features do need to be conditional.

I don't think it makes sense to display them prominently in the standard non-big-sky flow like this:

CleanShot 2025-01-31 at 20 21 32@2x

I also see they're semibold in the mockup. I'm not sure what the best way to customise this sort of thing on a per-flow basis. Especially the changes to the checkout 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-jackson p-jackson p-jackson requested changes

Assignees

@vykes-mac vykes-mac

Labels
Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Add AI copy to the plan comparison grid when in the Big Sky plans step
4 participants
@vykes-mac @matticbot @a8ci18n @p-jackson