E2E - Fix failing WP nightly tests #4743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4742
Changes proposed in this Pull Request
This PR mainly address the failing WP nightly E2E tests. The tests were failing due to a change on WP core as mentioned in #4742. Since E2E tests on WCPay doesn't make use of features provided by the Gutenberg plugin, we can safely remove it from being installed, solving the problem at hand.
This PR also, fixes a bug with populating artifact names on GitHub actions. The bug was introduced with this PR, where we removed matrix configurations from some tests and the while uploading the artifacts, the name was populated based on matrix values. The change proposed, replaces matrix with environment variables available.
Testing instructions
E2E Test - All
workflow against this branch and confirm that the environment setup doesn't fail and the tests are successful. Reference job - https://github.com/Automattic/woocommerce-payments/actions/runs/3037234294npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge