Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E - Fix failing WP nightly tests #4743

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Conversation

achyuthajoy
Copy link
Contributor

@achyuthajoy achyuthajoy commented Sep 12, 2022

Fixes #4742

Changes proposed in this Pull Request

This PR mainly address the failing WP nightly E2E tests. The tests were failing due to a change on WP core as mentioned in #4742. Since E2E tests on WCPay doesn't make use of features provided by the Gutenberg plugin, we can safely remove it from being installed, solving the problem at hand.

This PR also, fixes a bug with populating artifact names on GitHub actions. The bug was introduced with this PR, where we removed matrix configurations from some tests and the while uploading the artifacts, the name was populated based on matrix values. The change proposed, replaces matrix with environment variables available.

Testing instructions


  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@achyuthajoy achyuthajoy added pr: needs review category: e2e Issues and PRs related to e2e tests. category: devops Features and tools supporting dev process. labels Sep 12, 2022
@achyuthajoy achyuthajoy requested a review from a team September 12, 2022 12:17
Copy link
Contributor

@jbordonado jbordonado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@achyuthajoy achyuthajoy merged commit 526960d into develop Sep 12, 2022
@achyuthajoy achyuthajoy deleted the e2e/fix-failing-nightly-tests branch September 12, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: devops Features and tools supporting dev process. category: e2e Issues and PRs related to e2e tests. pr: ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E - WP nightly tests fail while installing & activating Gutenberg
2 participants