Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pendant: replacing CSS with theme.json settings for link elements #6179

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

matiasbenedetto
Copy link
Member

Changes proposed in this Pull Request:

Pendant: replacing CSS with theme.json settings for link elements

⚠️ The theme.json elements API for core/post-content settings works OK in the frontend but those styles are not applied in the editor. That is a bug potentially fixed by: WordPress/gutenberg#42270

Related issue(s):

#6170

@pbking
Copy link
Contributor

pbking commented Jul 11, 2022

This works with the plugin, however since this was released with hover states working without the plugin I believe we need to hang onto this until the feature has been released in core.

Sticking into the "yes but not yet" bucket unless there are objections.

Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but not until pseudo-selectors are available in WP Core.

@madhusudhand madhusudhand merged commit 616adeb into trunk Nov 7, 2022
@madhusudhand madhusudhand deleted the add/pendant-link-elements-styles branch November 7, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pendant: Implement latest Gutenberg link elements api for theme.json
4 participants