Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link interactivity (e.g. :hover) styles #6108

Open
4 of 8 tasks
MaggieCabrera opened this issue Jun 22, 2022 · 4 comments
Open
4 of 8 tasks

Link interactivity (e.g. :hover) styles #6108

MaggieCabrera opened this issue Jun 22, 2022 · 4 comments
Labels
[Type] Enhancement New feature or request

Comments

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Jun 22, 2022

In order to test WordPress/gutenberg#41786 and preparing for when that one gets merged we should implement link hover (and probably focus?) styles on our themes. I think we should start with:

And follow up to clean up CSS from any other themes that are using it.

There's a PR for Archeo already open.

@MaggieCabrera MaggieCabrera added the [Type] Enhancement New feature or request label Jun 22, 2022
@getdave getdave changed the title Link hover styles Link interactivity (e.g. :hover) styles Jun 22, 2022
@getdave
Copy link
Contributor

getdave commented Jun 22, 2022

Hope you don't mind I updated the title and desc to include that you might also consider implementing :focus just for a11y reasons 🙇

@jeffikus
Copy link
Contributor

jeffikus commented Aug 8, 2022

@madhusudhand @mikachan looks like only Blank Canvas is remaining on this list, any others we've missed?

@mikachan
Copy link
Member

mikachan commented Aug 9, 2022

Looking through our other themes, it looks like we may also need to update Livro, Skatepark and Stewart. I'll add them to the above list, they shouldn't take long to update.

@matiasbenedetto
Copy link
Member

In a conversation with @MaggieCabrera and @pbking we decided to remove this from the board until the pseudo selector feature lands WordPress core for two main reasons:

  • If we remove the CSS and the theme user doesn't have the Gutenberg plugin activated the link behavior will change and the link interactivity will no longer work.
  • If the user has Gutenberg activated the link behavior will be the same but the user will not receive any extra value because the UI to configure the link interactivity doesn't exist yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants