[Test] Archeo link interactivity states #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
8 tasks
MaggieCabrera
added
[Theme] Archeo
|
Though it's working as intended, I observe the following un-intended behaviour. Imagine the button behaviour as follows.
Now, if I set Buttons again needs explicit styling to reset it. Curator PR for reference. |
|
@madhusudhand I have a fix for that in WordPress/gutenberg#42072 |
|
I've removed the color change on hover from |
getdave
force-pushed
the
try/archeo-link-interactivity-states
branch
from
3da2422
to
4ea74c6
Compare
|
@mikachan I rebased. Is this now good to go? |
|
Yes, LGTM! |
mikachan
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is a complementary PR designed to stress test the proposed changes in WordPress/gutenberg#41786.
That PR enables interactivity states on
elementsto be defined intheme.json.This PR tries out that functionality on:
links.links within thecore/navigationblock.Testing
In order to test this PR you will need to be running a copy of Gutenberg with WordPress/gutenberg#41786 checked out and built.
Related issue(s):
WordPress/gutenberg#41786