Seedlet: removed hover states for buttons with custom background colors #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine by me; removes the hover as-advertised. Only thing to note, the "Secondary" color in the screencap above shows a hover color, however manually setting said secondary color on the button causes there to be no hover state (which was as I expected). |
Yes, the secondary color hover is working fine, this PR only removes the hover for the rest of them because they were all using the same color as the secondary. I'm not removing the secondary hover because that will alter people's sites as they are now and it's working as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR removes the hover states for buttons that have a custom background color.
Related issue(s):
Partially addresses #3110