-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seedlet: Fix custom color button hovers #3110
Comments
Same issue happens in Varia too: #3006 |
@kjellr do you think the same opacity solution would work for the outline buttons too? |
I think it's worth a try there too, yes. |
I opened a PR to fix the blue background (#3120), adding a proper hover state to buttons with custom colors should be done by GB, there's an issue open for that WordPress/gutenberg#27075 |
I went ahead and merged #3120, let me know if you think we should do anything else on the theme side. |
@MaggieCabrera I'm seeing a regression for outlined button hovers after this change. Can you confirm? |
The rest of this will be addressed in Gutenberg, so I suggest we close this one. |
When a user selects a totally custom color for their button, they have no hover state:
This is (because of the inlined color rule from Gutenberg, but it is also) not totally great.
Similarly, when a user chooses button colors that are part of our preset palette, we force a blue hover color. This frequently doesn't work:
Can we try using an opacity change for hovers when there is a custom color active? Something light — 90% opacity or so. That might solve both scenarios.
The text was updated successfully, but these errors were encountered: