Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet: Fix custom color button hovers #3110

Closed
kjellr opened this issue Jan 26, 2021 · 7 comments
Closed

Seedlet: Fix custom color button hovers #3110

kjellr opened this issue Jan 26, 2021 · 7 comments
Assignees
Labels
[Theme] Seedlet [Type] Bug Something isn't working

Comments

@kjellr
Copy link
Contributor

kjellr commented Jan 26, 2021

When a user selects a totally custom color for their button, they have no hover state:

Kapture 2021-01-26 at 15 44 26

This is (because of the inlined color rule from Gutenberg, but it is also) not totally great.

Similarly, when a user chooses button colors that are part of our preset palette, we force a blue hover color. This frequently doesn't work:

Kapture 2021-01-26 at 15 41 35
Kapture 2021-01-26 at 15 42 23

Can we try using an opacity change for hovers when there is a custom color active? Something light — 90% opacity or so. That might solve both scenarios.

@kjellr kjellr added [Type] Bug Something isn't working [Theme] Seedlet labels Jan 26, 2021
@MaggieCabrera
Copy link
Contributor

Same issue happens in Varia too: #3006

@MaggieCabrera
Copy link
Contributor

@kjellr do you think the same opacity solution would work for the outline buttons too?

@MaggieCabrera MaggieCabrera self-assigned this Jan 27, 2021
@kjellr
Copy link
Contributor Author

kjellr commented Jan 27, 2021

I think it's worth a try there too, yes.

@MaggieCabrera
Copy link
Contributor

I opened a PR to fix the blue background (#3120), adding a proper hover state to buttons with custom colors should be done by GB, there's an issue open for that WordPress/gutenberg#27075

@MaggieCabrera
Copy link
Contributor

I went ahead and merged #3120, let me know if you think we should do anything else on the theme side.

@kjellr
Copy link
Contributor Author

kjellr commented Jan 28, 2021

@MaggieCabrera I'm seeing a regression for outlined button hovers after this change. Can you confirm?

Kapture 2021-01-28 at 09 26 48

@scruffian
Copy link
Member

The rest of this will be addressed in Gutenberg, so I suggest we close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Seedlet [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants