-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add checks for Newspack plugin #1579
fix: add checks for Newspack plugin #1579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. This can probably also be solved by adding a ! empty()
to each attribute show*
attribute, that way the condition fails gracefully if shownewspack_phone_number
is false or doesn't exist at all.
Thanks @dkoo! |
# [2.2.0-alpha.1](v2.1.0...v2.2.0-alpha.1) (2023-11-16) ### Bug Fixes * add checks for Newspack plugin ([#1579](#1579)) ([b516a6f](b516a6f)) * **homepage-posts:** terms handling in category list ([#1596](#1596)) ([55dbf42](55dbf42)) * **modal-checkout:** place order button width ([b48efcb](b48efcb)), closes [#1572](#1572) ### Features * add width control to the Checkout block ([#1583](#1583)) ([3f75c1e](3f75c1e)) * **cwv:** inline HPB styles in a style tag ([#1548](#1548)) ([dea8d93](dea8d93)) * **modal-checkout:** display item name on success ([a3a03df](a3a03df)) * update subscribe patterns to use Newspack block ([#1580](#1580)) ([70088e2](70088e2))
🎉 This PR is included in version 2.2.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [2.2.0](v2.1.0...v2.2.0) (2023-11-27) ### Bug Fixes * add checks for Newspack plugin ([#1579](#1579)) ([b516a6f](b516a6f)) * **homepage-posts:** terms handling in category list ([#1596](#1596)) ([55dbf42](55dbf42)) * **modal-checkout:** place order button width ([b48efcb](b48efcb)), closes [#1572](#1572) ### Features * add width control to the Checkout block ([#1583](#1583)) ([3f75c1e](3f75c1e)) * **cwv:** inline HPB styles in a style tag ([#1548](#1548)) ([dea8d93](dea8d93)) * **modal-checkout:** display item name on success ([a3a03df](a3a03df)) * update subscribe patterns to use Newspack block ([#1580](#1580)) ([70088e2](70088e2))
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR adds some checks to the Author Profile and Author List block output, so it doesn't display warnings when the Newspack Plugin is deactivated.
See: 1200550061930446-as-1205176822910070
How to test the changes in this Pull Request:
Warning: Undefined array key “shownewspack_role” in /srv/users/user8bdc4063/apps/user8bdc4063/public/wp-content/plugins/newspack-blocks/src/templates/author-profile-card.php on line 31
).Other information: