Inline HPB styles in a style tag #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
requested changes
Nov 3, 2023
|
Good catch! Fixed in f97e39a |
miguelpeixe
approved these changes
Nov 6, 2023
matticbot
pushed a commit
that referenced
this pull request
Nov 16, 2023
# [2.2.0-alpha.1](v2.1.0...v2.2.0-alpha.1) (2023-11-16) ### Bug Fixes * add checks for Newspack plugin ([#1579](#1579)) ([b516a6f](b516a6f)) * **homepage-posts:** terms handling in category list ([#1596](#1596)) ([55dbf42](55dbf42)) * **modal-checkout:** place order button width ([b48efcb](b48efcb)), closes [#1572](#1572) ### Features * add width control to the Checkout block ([#1583](#1583)) ([3f75c1e](3f75c1e)) * **cwv:** inline HPB styles in a style tag ([#1548](#1548)) ([dea8d93](dea8d93)) * **modal-checkout:** display item name on success ([a3a03df](a3a03df)) * update subscribe patterns to use Newspack block ([#1580](#1580)) ([70088e2](70088e2))
|
🎉 This PR is included in version 2.2.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 27, 2023
# [2.2.0](v2.1.0...v2.2.0) (2023-11-27) ### Bug Fixes * add checks for Newspack plugin ([#1579](#1579)) ([b516a6f](b516a6f)) * **homepage-posts:** terms handling in category list ([#1596](#1596)) ([55dbf42](55dbf42)) * **modal-checkout:** place order button width ([b48efcb](b48efcb)), closes [#1572](#1572) ### Features * add width control to the Checkout block ([#1583](#1583)) ([3f75c1e](3f75c1e)) * **cwv:** inline HPB styles in a style tag ([#1548](#1548)) ([dea8d93](dea8d93)) * **modal-checkout:** display item name on success ([a3a03df](a3a03df)) * update subscribe patterns to use Newspack block ([#1580](#1580)) ([70088e2](70088e2))
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Inlines the critical parts of CSS needed by the Homepage Posts Block, in order to get rid of layout shift happening when the file-based CSS stylesheet is loaded.
To demonstrate, here's a recording of a (throttled) page load on
master:And here's how it looks like on this branch:
If this strategy proves effective in production environment, it can be enhanced by moving more of the static styles from
view.cssto the dynamically created inline stylesheet.How to test the changes in this Pull Request:
master, only faster** use DevTools' Network speed throttling to observe it better
Other information: