Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add checks for Newspack plugin #1579

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds some checks to the Author Profile and Author List block output, so it doesn't display warnings when the Newspack Plugin is deactivated.

See: 1200550061930446-as-1205176822910070

How to test the changes in this Pull Request:

  1. Add an Author Profile and Author List block to a page; publish.
  2. Navigate to WP Admin > Plugins, and deactivate the Newspack Plugin.
  3. View your page on the frontend, and note the warnings (example: Warning: Undefined array key “shownewspack_role” in /srv/users/user8bdc4063/apps/user8bdc4063/public/wp-content/plugins/newspack-blocks/src/templates/author-profile-card.php on line 31).
  4. Apply the PR.
  5. Confirm the warnings are gone.
  6. Reactivate the Newspack Plugin.
  7. Edit one of the authors the block displays and populate one of the Newspack fields (Employeer, Job Title...).
  8. View the block on the front-end and confirm that the fields still display.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. This can probably also be solved by adding a ! empty() to each attribute show* attribute, that way the condition fails gracefully if shownewspack_phone_number is false or doesn't exist at all.

@laurelfulford
Copy link
Contributor Author

Thanks @dkoo!

@laurelfulford laurelfulford merged commit b516a6f into master Nov 4, 2023
8 checks passed
@laurelfulford laurelfulford deleted the fix/author-block-without-newspack-plugin branch November 4, 2023 00:58
matticbot pushed a commit that referenced this pull request Nov 16, 2023
# [2.2.0-alpha.1](v2.1.0...v2.2.0-alpha.1) (2023-11-16)

### Bug Fixes

* add checks for Newspack plugin ([#1579](#1579)) ([b516a6f](b516a6f))
* **homepage-posts:** terms handling in category list ([#1596](#1596)) ([55dbf42](55dbf42))
* **modal-checkout:** place order button width ([b48efcb](b48efcb)), closes [#1572](#1572)

### Features

* add width control to the Checkout block ([#1583](#1583)) ([3f75c1e](3f75c1e))
* **cwv:** inline HPB styles in a style tag ([#1548](#1548)) ([dea8d93](dea8d93))
* **modal-checkout:** display item name on success ([a3a03df](a3a03df))
* update subscribe patterns to use Newspack block ([#1580](#1580)) ([70088e2](70088e2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 27, 2023
# [2.2.0](v2.1.0...v2.2.0) (2023-11-27)

### Bug Fixes

* add checks for Newspack plugin ([#1579](#1579)) ([b516a6f](b516a6f))
* **homepage-posts:** terms handling in category list ([#1596](#1596)) ([55dbf42](55dbf42))
* **modal-checkout:** place order button width ([b48efcb](b48efcb)), closes [#1572](#1572)

### Features

* add width control to the Checkout block ([#1583](#1583)) ([3f75c1e](3f75c1e))
* **cwv:** inline HPB styles in a style tag ([#1548](#1548)) ([dea8d93](dea8d93))
* **modal-checkout:** display item name on success ([a3a03df](a3a03df))
* update subscribe patterns to use Newspack block ([#1580](#1580)) ([70088e2](70088e2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants