Site Editor: dashboard link compat for Gutenberg 14.5

[mattwiebe]

Gutenberg 14.5 has removed the slotfill we formerly used for the dashboard link override, instead introducing a __experimentalDashboardLink setting.

This replaces Automattic/wp-calypso#69929

Fixes Automattic/wp-calypso#70074

Changes proposed in this Pull Request:

• Change the Site Editor < Dashboard link to WP.com Home

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

WPCom Simple

1. On your sandbox, run run bin/jetpack-downloader test add/site-editor-dashboard-compat
2. Apply to a sandboxed wp.com site
3. Ensure that your Site Editor's < Dashboard link points to wordpress.com/home/SITE_SLUG rather than SITE_SLUG.wordpress.com/wp-admin/site-editor.php

WoA

1. Use your favourite method to get this branch running on an WoA Developer blog
2. In the Site Editor, same as point 3 above.
3. Disable Editing Toolkit Plugin
4. Verify dashboard link again

NOTE: given that this supersedes Automattic/wp-calypso#70074 it will not necessarily appear to change anything on WP.com Simple, since both filters will be simultaneously operable. We get a truer test on Atomic by disabling the ETK plugin.

[github-actions]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack add/site-editor-dashboard-compat to get started. More details: p9dueE-5Nn-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ⚠️ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: January 3, 2023.
• Scheduled code freeze: December 26, 2022.

[agrullon95]

Tests

I commented out the dashboard link logic inside of ETK WPCOM_Block_Editor_Nav_Sidebar class and synced this PR jetpack to WPCOM.

• Simple Site - Verify Site Editor Dashboard link redirects user to wordpress.com/home/[SITE_SLUG] instead of [SITE_SLUG]/wp-admin/index.php

I disabled ETK plugin and switched to this Jetpack PR using Jetpack Beta tester.

• Atomic Site - Verify Site Editor Dashboard link redirects user to wordpress.com/home/[SITE_SLUG] instead of [SITE_SLUG]/wp-admin/index.php

[anomiex]

I don't know how this works post-Fusion. Excited to find out.

Once the build is complete, you run bin/jetpack-downloader test <branch> on your sandbox.

There's an automated comment that reminds you, in case you forget.

[mattwiebe]

@anomiex thank you!

[anomiex]

Looks like this will only affect wpcom Simple and Atomic, and I see someone has already tested those cases.

Left an inline comment, but it probably should not actually be applied in this PR for the reason given therein.

[anomiex]

Normally I'd suggest doing something like this here, just in case the value contains something weird.

Suggested change

	$settings['__experimentalDashboardLink'] = 'https://wordpress.com/home/' . $this->domain;
	$settings['__experimentalDashboardLink'] = 'https://wordpress.com/home/' . rawurlencode( $this->domain );

But it looks like there's a ton of other code in this file already not doing that, and the value is even being munged to replace / characters (probably for exactly that lack), so doing it only here would be inconsistent and might even break something depending on the unencoded behavior.

[mattwiebe]

Yeah keeping consistent is usually better than being "right", but good to notice 👍

[mattwiebe]

@anomiex the "PR is up to date" job was stuck in a weird state (it said here that it failed but clicking the Details link led to results from another PR) so I just did a rebase and pushed the branch back up and of course that dismisses your approving review!

And now after that, the continuous-integration/a8c-teamcity job is also failing, but clicking through to the job shows a passing job. Very confusing!

Anyway, need another quick 👍 or you can just merge this yourself.

[anomiex]

The "PR is up-to-date" check runs in two different contexts. When the PR itself is updated it runs to check the PR, and when the tags it checks against are updated it runs to check every open PR. Probably the weird state was the latter case.

I think the continuous-integration/a8c-teamcity check is still being developed. You might ask in the jetpack-quality channel with questions.

[anomiex]

BTW, a rebase will always dismiss existing reviews, while if you do a trunk merge instead it often keeps them.

[mattwiebe]

Thanks again @anomiex !

[Addison-Stavlo]

It looks like this may be causing this issue Automattic/wp-calypso#71760 .

In short in testing flows on horizon, leaving the site editor on horizon now bumps you into the production environment.