Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widget-conditions: fix regression introduced in #22414 #22457

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

yoavf
Copy link
Contributor

@yoavf yoavf commented Jan 23, 2022

Fixes #22460.

This commit syncs r238742-wpcom.

In #22414, a couple of the changes switched to strict equality when the actual data compared had different types.
This meant that if a legacy widget was saved with visibility on a specific page, it would never show on that page (or any other page).
This was documented in Automattic/wp-calypso#60352 and Automattic/wp-calypso#60355

Changes proposed in this Pull Request:

  • Fixes regression by casting the page ID data from the visiblity rule to int

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Add a legacy widget to a theme with a widget area
  • Set the widget to be visible on a specific page
  • Update
  • Visit that page, widget should be visible

@yoavf yoavf added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Widget Visibility [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 23, 2022
@yoavf yoavf added this to the jetpack/10.6 milestone Jan 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 24, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 24, 2022
@jeherve jeherve enabled auto-merge (squash) January 24, 2022 10:45
@jeherve jeherve merged commit 56c07f2 into master Jan 24, 2022
@jeherve jeherve deleted the fusion-sync/yoavf/r238742-wpcom-1642953249 branch January 24, 2022 22:27
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 24, 2022
samiff pushed a commit that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widget Visibility [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Tested on WP.com Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended [Type] Dotcom Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget Visibility: Widget preview broken on WPCOM when visiblity settings are enabled for legacy widgets
3 participants