Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS: Widget Visibility #22414

Merged
merged 7 commits into from
Jan 20, 2022
Merged

PHPCS: Widget Visibility #22414

merged 7 commits into from
Jan 20, 2022

Conversation

samiff
Copy link
Contributor

@samiff samiff commented Jan 19, 2022 •
edited
Loading

Changes proposed in this Pull Request:

PHPCS cleanup Widget Visibility module files.

Jetpack product discussion

Fixes #21979

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Make sure the Widget Visibility module is turned on.
  • Add a test widget and try changing the visibility settings.
  • Look for any errors when interacting with the widget from editor or frontend.

@samiff samiff self-assigned this Jan 19, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello samiff! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D73402-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Unit Tests labels Jan 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

@samiff samiff added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Jan 19, 2022
@samiff
Copy link
Contributor Author

samiff commented Jan 19, 2022

Regarding the file renaming e187b02

Just verifying I would: get this PR merged, deploy the wpcom diff, then modify the filename being synced in build-plugin-files.php?

@jeherve
Copy link
Member

jeherve commented Jan 20, 2022

Just verifying I would: get this PR merged, deploy the wpcom diff, then modify the filename being synced in build-plugin-files.php?

Yes, although I would recommend committing to WordPress.com in 2 diffs: one to add the new file, another to start requiring that file instead of the existing one.

jeherve
jeherve approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jeherve jeherve added this to the jetpack/10.6 milestone Jan 20, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 20, 2022
@samiff samiff merged commit 760338d into master Jan 20, 2022
@samiff samiff deleted the phpcs/widget-visibility branch January 20, 2022 18:26
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 20, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D73402-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@samiff
Copy link
Contributor Author

samiff commented Jan 20, 2022

r238622-wpcom

@samiff samiff mentioned this pull request Jan 20, 2022
Merged
@yoavf yoavf mentioned this pull request Jan 23, 2022
Merged
jeherve added a commit that referenced this pull request Jan 24, 2022
@yoavf @jeherve
widget-conditions: fix regression introduced in #22414 (#22457)
56c07f2 
Co-authored-by: Jeremy Herve <[email protected]>
samiff pushed a commit that referenced this pull request Jan 28, 2022
@yoavf @jeherve @samiff
[not verified] widget-conditions: fix regression introduced in #22414 (…
90d1bb5 
…#22457)

Co-authored-by: Jeremy Herve <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@samiff samiff

Labels
[Feature] Widget Visibility [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Janitorial Unit Tests
Projects
None yet
Milestone
jetpack/10.6
Development

Successfully merging this pull request may close these issues.

PHPCS: Widget Visibility
3 participants
@samiff @matticbot @jeherve