Search: Add essential scaffolding for package by jsnmoon · Pull Request #21814 · Automattic/jetpack

jsnmoon · 2021-11-19T00:50:31Z

Changes proposed in this Pull Request:

Adds essential scaffolding to the Search package.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Ensure that the changes look reasonable and that the new pnpm script commands all work as expected in projects/packages/search:

pnpm clean-all - clean up builds and dependencies
pnpm build - would only echo 'Not yet implemented.'
pnpm build-development - would only echo a couple of 'Not yet implemented.'
pnpm build-production - would only echo a couple of 'Not yet implemented.'
pnpm test - runs jest, currently no tests
pnpm test-size - would only echo 'Not yet implemented.'

matticbot · 2021-11-19T00:50:38Z

Caution: This PR has changes that must be merged to WordPress.com
Hello jsnmoon! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D70350-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

github-actions · 2021-11-19T00:51:29Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
⚠️ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

Next scheduled release: December 7, 2021.
Scheduled code freeze: November 30, 2021.

bluefuton · 2021-11-21T21:25:00Z

@kangzj can we add the list of pnpm commands to the testing instructions please?

kangzj · 2021-11-21T21:28:42Z

@kangzj can we add the list of pnpm commands to the testing instructions please?

Hi @bluefuton thanks for the speedy review. commands added.

bluefuton

Looks reasonable and new pnpm tasks run as expected.

kangzj · 2021-11-22T23:09:59Z

Hi @anomiex thanks heaps for all the suggestions, they are super helpful. I've addressed them. Could you please have another look? thanks.

jeherve

This looks sane to me. I had a suggestion though: since we're adding quite a few new files, I think you'll need to update projects/packages/search/.gitattributes accordingly, so we do not start shipping dev and config files in production in the next release.

kangzj · 2021-11-23T22:15:45Z

This looks sane to me. I had a suggestion though: since we're adding quite a few new files, I think you'll need to update projects/packages/search/.gitattributes accordingly, so we do not start shipping dev and config files in production in the next release. @jeherve

Good catch .gitattributes is updated now in ab13e97

This won't work as you intend, the environment variables when set this way only apply to the command they're attached to, not later commands after &&. What you'd have to do is like @anomiex

TIL. Thanks. Build commands feedback addressed in 9a24050

you might need to set a config to avoid browserslist's default that still includes IE11. @anomiex

Added in e7ef4a6

jeherve

This looks good to me, let's give it a try!

github-actions · 2021-11-24T20:11:19Z

Great news! One last step: head over to your WordPress.com diff, D70350-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

kangzj · 2021-11-24T21:52:23Z

🚢 wpcom-235612

# By Jeremy Herve (5) and others # Via GitHub * master: (26 commits) Colors: update Primary green reference to match latest brand book (#21741) JS Connection: Moves registerSite logic to the store (#21732) Search: Add essential scaffolding for package (#21814) Search: avoid registering the widget when the module is not active (#21588) Add Video Tracks Support to VideoPress Block (#21578) Add deprecated to VideoPress block (#21802) Admin Menu: Make API tests compatible with WPCOM (#21850) External Media: Short-circuit requests earlier in the stack (#21854) Add Busy State to License Activation Flow Button (#21861) Fixed an issue with screen resolutions of under 783px that caused the content to not be properly displayed when the nav-unification is expanded on wp-admin. (#21869) E2E tests: migrate from Jest to Playwright runner (#21848) Update reCAPTCHA constants to match Google's Verbage (#12289) JITM: Sideload Jetpack Boost functionality (#21860) Connection: properly add GET-parameters for the `fetchAuthorizationUrl` API call (#21750) License Flow: Assorted Styling Improvements (#21859) JITM: Sideload Jetpack Backup (#21719) Widget Visibility: Apply widget filtering to customizer preview (#21505) jetpack: Avoid generating unused JS for static-site-generator assets (#21789) Nav Unification: Support absolute URLs in upsell nudges (#21821) RePublicize: Enable the block editor UI by default (#21855) ... # Conflicts: # projects/plugins/boost/tests/e2e/lib/env/prerequisites.js # projects/plugins/boost/tests/e2e/lib/setupTests.js

jsnmoon added [Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Nov 19, 2021

jsnmoon requested a review from a team November 19, 2021 00:50

jsnmoon self-assigned this Nov 19, 2021

matticbot added the Touches WP.com Files label Nov 19, 2021

jsnmoon added the [Status] In Progress label Nov 19, 2021

jsnmoon added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] In Progress labels Nov 19, 2021

github-actions Bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Nov 21, 2021

kangzj requested a review from bluefuton November 21, 2021 21:24

kangzj self-assigned this Nov 21, 2021

bluefuton reviewed Nov 21, 2021

View reviewed changes

Comment thread projects/packages/search/package.json Outdated

bluefuton previously approved these changes Nov 22, 2021

View reviewed changes

bluefuton added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Nov 22, 2021

This was referenced Nov 22, 2021

Search package: duplicate dashboard dependencies to package (1/3) #21840

Merged

Search package: Add new state store to search dashboard (2/3) #21841

Merged

Search package: changes to the duplicated components (3/3) #21842

Merged

anomiex reviewed Nov 22, 2021

View reviewed changes

anomiex added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Nov 22, 2021

kangzj dismissed bluefuton’s stale review via 5612e91 November 22, 2021 20:28

Jason Moon added 4 commits November 23, 2021 09:52

[not verified] Add eslint config

c28fbe8

[not verified] Add babel config

048b8a8

[not verified] Add postcss config

ce6476c

[not verified] Add jest config

a364f44

kangzj added the [Status] Needs Review This PR is ready for review. label Nov 22, 2021

kangzj enabled auto-merge (squash) November 22, 2021 23:10

jeherve requested changes Nov 23, 2021

View reviewed changes

jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Nov 23, 2021

anomiex reviewed Nov 23, 2021

View reviewed changes

Comment thread projects/packages/search/composer.json

Comment thread projects/packages/search/package.json Outdated

kangzj added 4 commits November 24, 2021 10:47

change file list to be included/excluded for production

ab13e97

fix build env issue

9a24050

merge from master

b6e2be8

update jetpack content-hash

86b1f48

kangzj requested review from anomiex and jeherve November 23, 2021 22:16

kangzj added 3 commits November 24, 2021 11:30

added browserslist

e7ef4a6

update jetpack api version

1f9c292

update dependency versions

80b71cd

kangzj added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 23, 2021

jeherve approved these changes Nov 24, 2021

View reviewed changes

jeherve added this to the jetpack/10.4 milestone Nov 24, 2021

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 24, 2021

kangzj merged commit 5502597 into master Nov 24, 2021

kangzj deleted the add/search-package-skeleton branch November 24, 2021 20:10

github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 24, 2021

anomiex mentioned this pull request May 27, 2026

Webpack: opt-in filesystem cache + stop wiping .cache/ on clean #49174

Merged

1 task done

Conversation

jsnmoon commented Nov 19, 2021 • edited by kangzj Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

matticbot commented Nov 19, 2021

Uh oh!

github-actions Bot commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bluefuton commented Nov 21, 2021

Uh oh!

kangzj commented Nov 21, 2021

Uh oh!

Uh oh!

bluefuton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kangzj commented Nov 22, 2021

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kangzj commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 24, 2021

Uh oh!

kangzj commented Nov 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jsnmoon commented Nov 19, 2021 •

edited by kangzj

Loading

github-actions Bot commented Nov 19, 2021 •

edited

Loading

kangzj commented Nov 23, 2021 •

edited

Loading