Skip to content

JITM: Sideload Jetpack Backup - #21719

Merged
dereksmart merged 12 commits into
masterfrom
add/jitm-sideload-backup-plugin
Nov 23, 2021
Merged

JITM: Sideload Jetpack Backup#21719
dereksmart merged 12 commits into
masterfrom
add/jitm-sideload-backup-plugin

Conversation

@dereksmart

@dereksmart dereksmart commented Nov 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

Adds the logic necessary to enable installing and activating the Jetpack Backup plugin via JITM. It mimics the behavior and code pattern of the CreativeMail JITM sideloading.

This is in preparation of enabling the JITM in wpcom later when we're ready, so that we don't need to wait for another release. The wpcom diff linked below is not up for review, but is useful for testing the PR.

Jetpack product discussion

p1HpG7-dzq-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Set up:

  • Connect to wpcom sandbox
  • Apply D69991-code to sandbox
  • Make sure Jetpack Backup is not installed on the Jetpack site
  • You'll see the JITM on the main wp-admin dashboard as well as the Jetpack dashboard.

Successful install:

  • Clicking it should install/activate and navigate you to the Jetpack Backup plugin UI.
  • Check to see if the /s/jetpack-jitm-plugin-install/ MC stat was bumped properly doing this in separate PR

Failed install:

  • Force a failure in try_install(). I tested by manually modifying the code.
  • Click the JITM to install. You should get redirected to the plugin search page in wp-admin with jetpack-backup results pre-populated.
  • You should see a wp-admin notice telling you about the failure.
  • Check to see if the /s/jetpack-jitm-plugin-install/ MC stat was bumped properly doing this in separate PR

@dereksmart dereksmart added [Status] In Progress [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Package] Jitm labels Nov 11, 2021
@matticbot

matticbot commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello dereksmart! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D69994-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions Bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Focus] Compatibility Ensuring our products play well with third-parties labels Nov 11, 2021
@github-actions

github-actions Bot commented Nov 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

@dereksmart dereksmart added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Nov 23, 2021
@dereksmart dereksmart added this to the jetpack/10.4 milestone Nov 23, 2021
jeherve
jeherve requested changes Nov 23, 2021
View reviewed changes

@jeherve jeherve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I left a few remarks below.

Also, since you're updating the JITM package, you'll need to bump the version number for it, as mentioned here :
https://github.com/Automattic/jetpack/runs/4302922959?check_suite_focus=true#step:4:558

Comment thread projects/plugins/jetpack/3rd-party/jetpack-backup.php Outdated
Comment thread projects/plugins/jetpack/3rd-party/jetpack-backup.php Outdated
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Nov 23, 2021
@jeherve jeherve added the Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Nov 23, 2021
@dereksmart dereksmart added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 23, 2021
@dereksmart
dereksmart requested a review from jeherve November 23, 2021 18:15
jeherve
jeherve approved these changes Nov 23, 2021
View reviewed changes

@jeherve jeherve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 23, 2021
@dereksmart
dereksmart enabled auto-merge (squash) November 23, 2021 18:38
@dereksmart
dereksmart merged commit 4a2df65 into master Nov 23, 2021
@dereksmart
dereksmart deleted the add/jitm-sideload-backup-plugin branch November 23, 2021 19:05
@github-actions

github-actions Bot commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Great news! One last step: head over to your WordPress.com diff, D69994-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 23, 2021
@dereksmart

dereksmart commented Nov 23, 2021

Copy link
Copy Markdown
Contributor Author

merged wpcom diff in r235525-wpcom

@dereksmart dereksmart mentioned this pull request Nov 23, 2021
Merged
davidlonjon added a commit that referenced this pull request Nov 25, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-tests
7b19032 
# By Jeremy Herve (5) and others
# Via GitHub
* master: (26 commits)
  Colors: update Primary green reference to match latest brand book (#21741)
  JS Connection: Moves registerSite logic to the store (#21732)
  Search: Add essential scaffolding for package (#21814)
  Search: avoid registering the widget when the module is not active (#21588)
  Add Video Tracks Support to VideoPress Block (#21578)
  Add deprecated to VideoPress block (#21802)
  Admin Menu: Make API tests compatible with WPCOM (#21850)
  External Media: Short-circuit requests earlier in the stack (#21854)
  Add Busy State to License Activation Flow Button (#21861)
  Fixed an issue with screen resolutions of under 783px that caused the content to not be properly displayed when the nav-unification is expanded on wp-admin. (#21869)
  E2E tests: migrate from Jest to Playwright runner (#21848)
  Update reCAPTCHA constants to match Google's Verbage (#12289)
  JITM: Sideload Jetpack Boost functionality  (#21860)
  Connection: properly add GET-parameters for the `fetchAuthorizationUrl` API call (#21750)
  License Flow: Assorted Styling Improvements (#21859)
  JITM: Sideload Jetpack Backup (#21719)
  Widget Visibility: Apply widget filtering to customizer preview (#21505)
  jetpack: Avoid generating unused JS for static-site-generator assets (#21789)
  Nav Unification: Support absolute URLs in upsell nudges (#21821)
  RePublicize: Enable the block editor UI by default (#21855)
  ...

# Conflicts:
#	projects/plugins/boost/tests/e2e/lib/env/prerequisites.js
#	projects/plugins/boost/tests/e2e/lib/setupTests.js
@dereksmart dereksmart mentioned this pull request Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@dereksmart dereksmart

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Focus] Compatibility Ensuring our products play well with third-parties [Package] Jitm [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files

Projects

None yet

Milestone

jetpack/10.4

Development

Successfully merging this pull request may close these issues.

3 participants

@dereksmart @matticbot @jeherve