Skip to content

Update Licensing JS Package to make it support all Jetpack products - #21770

Merged
rcanepa merged 5 commits into
masterfrom
add/licensing-support-for-all-jetpack-products
Nov 18, 2021
Merged

rcanepa merged 5 commits into
masterfrom
add/licensing-support-for-all-jetpack-products

Conversation

@rcanepa

@rcanepa rcanepa commented Nov 16, 2021 •

Copy link
Copy Markdown
Contributor

Fixes 1201096622142517-as-1201380925825213

Changes proposed in this Pull Request:

  • In Add Licensing JS Package #21730, only support for Jetpack Backup Daily and Jetpack Security Daily was added. This PR extends the support for the rest of the Jetpack products. In practice, after a user activates a Jetpack product via a license key, they will see a congratulatory UI specific to the product they activated.

Jetpack product discussion

  • p1HpG7-cSg-p2

Does this pull request change what data or activity we track or use?

  • No. It does not.

Testing instructions:

  • Package is not connected to any plugin in this PR. Follow-up PRs will contain more detailed instructions for testing UX.
  • Verify tests pass cd projects/js-packages/licensing/ && pnpm test

@rcanepa rcanepa added [Status] Needs Team Review Obsolete. Use Needs Review instead. [JS Package] Licensing labels Nov 16, 2021
@rcanepa rcanepa added this to the jetpack/10.4 milestone Nov 16, 2021
@rcanepa
rcanepa requested review from a team and cbauerman November 16, 2021 22:31
@rcanepa rcanepa self-assigned this Nov 16, 2021
@github-actions github-actions Bot added the RNA label Nov 16, 2021
@github-actions

github-actions Bot commented Nov 16, 2021 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@cbauerman
cbauerman force-pushed the add/licensing-support-for-all-jetpack-products branch from 47655a7 to 125afb2 Compare November 17, 2021 16:40
@rcanepa
rcanepa force-pushed the add/licensing-support-for-all-jetpack-products branch from 125afb2 to cf8e27b Compare November 17, 2021 17:13

@elliottprogrammer elliottprogrammer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be good here! All code looks good. Unit tests are passing. I don't see any issues.
Also, I tested the full activation flow by merging #21764 into this branch. I activated license keys for both Jetpack Backup T1 and also Jetpack Security Monthly T1, in which the correct JetpackProductDetails were shown for both products.
Everything LGTM! 👍

@rcanepa rcanepa added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Nov 17, 2021
@matticbot

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello rcanepa! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D70312-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@sdixon194 sdixon194 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a go!

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 18, 2021
@rcanepa
rcanepa merged commit 98f53e0 into master Nov 18, 2021
@rcanepa
rcanepa deleted the add/licensing-support-for-all-jetpack-products branch November 18, 2021 17:47
@github-actions github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 18, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Great news! One last step: head over to your WordPress.com diff, D70312-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@rcanepa

rcanepa commented Nov 18, 2021

Copy link
Copy Markdown
Contributor Author

r235278-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants