Repository navigation
Update Licensing JS Package to make it support all Jetpack products - #21770
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
47655a7 to
125afb2
Compare
125afb2 to
cf8e27b
Compare
elliottprogrammer
left a comment
There was a problem hiding this comment.
Everything appears to be good here! All code looks good. Unit tests are passing. I don't see any issues.
Also, I tested the full activation flow by merging #21764 into this branch. I activated license keys for both Jetpack Backup T1 and also Jetpack Security Monthly T1, in which the correct JetpackProductDetails were shown for both products.
Everything LGTM! 👍
…rt-for-all-jetpack-products
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Great news! One last step: head over to your WordPress.com diff, D70312-code, and commit it. Thank you! |
|
r235278-wpcom |
Fixes 1201096622142517-as-1201380925825213
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: