Skip to content

Add Licensing JS Package - #21730

Merged
cbauerman merged 20 commits into
masterfrom
add/license-flow-js-package
Nov 16, 2021
Merged

cbauerman merged 20 commits into
masterfrom
add/license-flow-js-package

Conversation

@cbauerman

Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

  • Add new Licensing JS Package to power license activation flow in Plugins

Jetpack product discussion

  • p1HpG7-cSg-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Package is not connected to any plugin in this PR
    • Follow-up PRs will contain more detailed instructions for testing UX.
  • Verify tests pass cd projects/js-packages/licensing/ && pnpm test

@cbauerman cbauerman added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Nov 12, 2021
@cbauerman cbauerman self-assigned this Nov 12, 2021
@matticbot

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello cbauerman! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D70048-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@cbauerman
cbauerman requested a review from a team November 12, 2021 20:06
@cbauerman cbauerman added this to the jetpack/10.4 milestone Nov 12, 2021
Comment thread .gitignore Outdated
@github-actions

github-actions Bot commented Nov 12, 2021 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Comment thread projects/js-packages/licensing/components/activation-screen-controls/style.scss Outdated
Comment thread projects/js-packages/licensing/components/activation-screen-controls/style.scss Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a note here just to remember that we will need to add a link here.

@cbauerman
cbauerman force-pushed the add/license-flow-js-package branch from 5994064 to abb45e0 Compare November 12, 2021 23:34
rcanepa
rcanepa previously approved these changes Nov 12, 2021

@rcanepa rcanepa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Code changes look fine and clearly establish the basis for the rest of the pieces of the UI that will come later in follow-up PRs. I have to say also that already tested most of these changes when they were part of a previous PR (closed in favor of this one).

Awesome work, Caleb!

@cbauerman cbauerman added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Nov 12, 2021
@cbauerman
cbauerman enabled auto-merge (squash) November 13, 2021 02:29

@jeherve jeherve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a first look. Thanks for adding the tests, that makes things a lot easier! I had a few remarks and questions, see below.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be an option to import the icon from @wordpress/icons instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning from @wordpress/icons ( the bottom icon ) seems like an acceptable substitute to the original ( the top icon )
Screen Shot 2021-11-15 at 10 14 10 AM

Comment thread projects/js-packages/licensing/components/activation-screen-controls/index.jsx Outdated
Comment thread projects/js-packages/licensing/components/activation-screen-controls/style.scss Outdated
Comment thread projects/js-packages/licensing/components/activation-screen-controls/style.scss Outdated
Comment thread projects/js-packages/licensing/index.jsx Outdated
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Nov 15, 2021
@cbauerman
cbauerman disabled auto-merge November 15, 2021 18:45
@cbauerman
cbauerman enabled auto-merge (squash) November 15, 2021 18:46
@cbauerman
cbauerman force-pushed the add/license-flow-js-package branch from 336e730 to b9f7eef Compare November 15, 2021 18:53
@cbauerman cbauerman added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 15, 2021

@jeherve jeherve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's merge this! 🚢 ⭐

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 16, 2021
@cbauerman
cbauerman merged commit e9f9498 into master Nov 16, 2021
@cbauerman
cbauerman deleted the add/license-flow-js-package branch November 16, 2021 12:03
@github-actions

Copy link
Copy Markdown
Contributor

Great news! One last step: head over to your WordPress.com diff, D70048-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 16, 2021
@anomiex

anomiex commented Nov 17, 2021

Copy link
Copy Markdown
Contributor

r235224-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants