Repository navigation
Add Licensing JS Package - #21730
Add Licensing JS Package#21730
Conversation
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Leaving a note here just to remember that we will need to add a link here.
5994064 to
abb45e0
Compare
rcanepa
left a comment
There was a problem hiding this comment.
LGTM.
Code changes look fine and clearly establish the basis for the rest of the pieces of the UI that will come later in follow-up PRs. I have to say also that already tested most of these changes when they were part of a previous PR (closed in favor of this one).
Awesome work, Caleb!
jeherve
left a comment
There was a problem hiding this comment.
I gave this a first look. Thanks for adding the tests, that makes things a lot easier! I had a few remarks and questions, see below.
There was a problem hiding this comment.
Would it be an option to import the icon from @wordpress/icons instead?
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
336e730 to
b9f7eef
Compare
jeherve
left a comment
There was a problem hiding this comment.
This looks good to me. Let's merge this! 🚢 ⭐
|
Great news! One last step: head over to your WordPress.com diff, D70048-code, and commit it. Thank you! |
|
r235224-wpcom |

Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
cd projects/js-packages/licensing/ && pnpm test