Skip to content

chore(release): bump desktop version to v2026.5.18 #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
May 17, 2026
Merged

chore(release): bump desktop version to v2026.5.18 #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/desktop-electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@opencode-ai/desktop-electron",
"private": true,
"version": "2026.5.17",
"version": "2026.5.18",
"type": "module",
"license": "Apache-2.0",
"homepage": "https://pawwork.ai",
Expand Down
3 changes: 2 additions & 1 deletion packages/desktop-electron/src/main/renderer-diagnostics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
} from "./renderer-diagnostics"

let roots: string[] = []
const posixPermissionsTest = process.platform === "win32" ? test.skip : test

@gemini-code-assist gemini-code-assist Bot May 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This custom alias can be removed in favor of using Bun's built-in test.if() modifier directly on the test case. This is more idiomatic and avoids the need for manual wrapping of test functions, ensuring consistency with modifiers like .only and .skip.

References
  1. When wrapping test functions to apply custom timeouts or configurations (e.g., for platform-specific stability), ensure that modifiers like .only and .skip are also wrapped to maintain consistent behavior across all test variants and avoid surprises during debugging.


async function tempRoot() {
const root = await mkdtemp(join(tmpdir(), "pawwork-renderer-diagnostics-"))
Expand Down Expand Up @@ -170,7 +171,7 @@ describe("renderer diagnostics recorder", () => {
expect(content).toContain("msg_11")
})

test("retention keeps the log intact when the existing file cannot be read", async () => {
posixPermissionsTest("retention keeps the log intact when the existing file cannot be read", async () => {

@gemini-code-assist gemini-code-assist Bot May 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of using a custom alias, leverage Bun's built-in test.if() modifier. This approach is more idiomatic and ensures that other test modifiers (such as .only or .skip) behave consistently across all platforms, which aligns with the repository rule regarding test function wrappers.

Suggested change
posixPermissionsTest("retention keeps the log intact when the existing file cannot be read", async () => {
test.if(process.platform !== "win32")("retention keeps the log intact when the existing file cannot be read", async () => {
References
  1. When wrapping test functions to apply custom timeouts or configurations (e.g., for platform-specific stability), ensure that modifiers like .only and .skip are also wrapped to maintain consistent behavior across all test variants and avoid surprises during debugging.

const root = await tempRoot()
const recorder = createRendererDiagnosticsRecorder({
root,
Expand Down
Loading