chore(release): bump desktop version to v2026.5.18 - #706
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Suggested priority: P2 (includes user-path files (packages/desktop-electron/src/main/renderer-diagnostics.test.ts)).
P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.
There was a problem hiding this comment.
Code Review
This pull request updates the package version and introduces a platform-specific skip for a diagnostic test on Windows using a custom alias. The reviewer suggests replacing this custom alias with Bun's built-in test.if() modifier to improve idiomatic consistency and ensure that other test modifiers like .only or .skip behave correctly across platforms.
| } from "./renderer-diagnostics" | ||
|
|
||
| let roots: string[] = [] | ||
| const posixPermissionsTest = process.platform === "win32" ? test.skip : test |
There was a problem hiding this comment.
This custom alias can be removed in favor of using Bun's built-in test.if() modifier directly on the test case. This is more idiomatic and avoids the need for manual wrapping of test functions, ensuring consistency with modifiers like .only and .skip.
References
- When wrapping test functions to apply custom timeouts or configurations (e.g., for platform-specific stability), ensure that modifiers like .only and .skip are also wrapped to maintain consistent behavior across all test variants and avoid surprises during debugging.
| }) | ||
|
|
||
| test("retention keeps the log intact when the existing file cannot be read", async () => { | ||
| posixPermissionsTest("retention keeps the log intact when the existing file cannot be read", async () => { |
There was a problem hiding this comment.
Instead of using a custom alias, leverage Bun's built-in test.if() modifier. This approach is more idiomatic and ensures that other test modifiers (such as .only or .skip) behave consistently across all platforms, which aligns with the repository rule regarding test function wrappers.
| posixPermissionsTest("retention keeps the log intact when the existing file cannot be read", async () => { | |
| test.if(process.platform !== "win32")("retention keeps the log intact when the existing file cannot be read", async () => { |
References
- When wrapping test functions to apply custom timeouts or configurations (e.g., for platform-specific stability), ensure that modifiers like .only and .skip are also wrapped to maintain consistent behavior across all test variants and avoid surprises during debugging.
Summary
2026.5.18.chmod(0)assumption that Windows does not enforce the same way.Why
v2026.5.17shipped before the latest onboarding, model-picker, persistence, label-governance, and diagnostics-lag fixes. The currentdevrelease candidate also had a Windows advisory failure in the desktop diagnostics test suite. This PR prepares the next stable release and removes that advisory-only test mismatch.Related Issue
No dedicated release issue. This release includes recently merged work from #691, #692, #693, #694, #702, and #703.
Human Review Status
Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.
Review Focus
Please check that the version bump is limited to the desktop package and that the test change only scopes a POSIX-only file-permission assertion away from Windows without weakening the recorder behavior on POSIX platforms.
Risk Notes
Low product risk. The only code-adjacent change is test scope for a platform-specific permission assumption. Release risk is the normal desktop publishing path: macOS notarization, Windows build, release assets, updater metadata, and post-release verification still need to pass after merge.
How To Verify
Screenshots or Recordings
Not required. No visible UI change in this PR.
Checklist
bug,enhancement,task, ordocumentation), at least one primary routing label (app,ui,platform,harness, orci), and exactly one priority label (P0toP3, or I requested maintainer labelingdev, and my PR title and commit messages use Conventional Commits in English