Skip to content

chore(release): bump desktop version to v2026.5.18 - #706

Merged
Astro-Han merged 1 commit into
devfrom
codex/release-2026-5-18
May 17, 2026
Merged

chore(release): bump desktop version to v2026.5.18#706
Astro-Han merged 1 commit into
devfrom
codex/release-2026-5-18

Conversation

@Astro-Han

Copy link
Copy Markdown
Owner

Summary

  • Bump the desktop release version to 2026.5.18.
  • Scope the diagnostics retention unreadable-file test to POSIX permission semantics so Windows advisory does not fail on a chmod(0) assumption that Windows does not enforce the same way.

Why

v2026.5.17 shipped before the latest onboarding, model-picker, persistence, label-governance, and diagnostics-lag fixes. The current dev release candidate also had a Windows advisory failure in the desktop diagnostics test suite. This PR prepares the next stable release and removes that advisory-only test mismatch.

Related Issue

No dedicated release issue. This release includes recently merged work from #691, #692, #693, #694, #702, and #703.

Human Review Status

Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.

Review Focus

Please check that the version bump is limited to the desktop package and that the test change only scopes a POSIX-only file-permission assertion away from Windows without weakening the recorder behavior on POSIX platforms.

Risk Notes

Low product risk. The only code-adjacent change is test scope for a platform-specific permission assumption. Release risk is the normal desktop publishing path: macOS notarization, Windows build, release assets, updater metadata, and post-release verification still need to pass after merge.

How To Verify

Focused desktop diagnostics test: 11 pass / 0 fail with bun --cwd packages/desktop-electron test src/main/renderer-diagnostics.test.ts
Release typecheck: passed with bun --cwd packages/desktop-electron typecheck:release
Diff check: git diff --check passed with no whitespace errors

Screenshots or Recordings

Not required. No visible UI change in this PR.

Checklist

  • Human review status is stated above as pending, approved, or not required
  • I linked the related issue, or stated why there is no issue
  • This PR has exactly one type label (bug, enhancement, task, or documentation), at least one primary routing label (app, ui, platform, harness, or ci), and exactly one priority label (P0 to P3, or I requested maintainer labeling
  • I described the review focus and any meaningful risks
  • I listed the relevant verification steps and the key result for each
  • I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope
  • I manually checked visible UI or copy changes when needed, with screenshots or recordings
  • I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes
  • I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant
  • I reviewed the final diff for unrelated changes and suspicious dependency changes
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English

@Astro-Han Astro-Han added P0 Blocking / highest priority platform Electron shell, OS integration, packaging, updater, signing, paths, and permissions task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work labels May 17, 2026
@coderabbitai

coderabbitai Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 229f82c9-98d0-496b-a9f7-32d0632a43fd

📥 Commits

Reviewing files that changed from the base of the PR and between 8b6916f and 0504d03.

📒 Files selected for processing (2)
  • packages/desktop-electron/package.json
  • packages/desktop-electron/src/main/renderer-diagnostics.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/release-2026-5-18

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested priority: P2 (includes user-path files (packages/desktop-electron/src/main/renderer-diagnostics.test.ts)).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

@Astro-Han
Astro-Han merged commit 94b4792 into dev May 17, 2026
32 checks passed
@Astro-Han
Astro-Han deleted the codex/release-2026-5-18 branch May 17, 2026 16:32

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version and introduces a platform-specific skip for a diagnostic test on Windows using a custom alias. The reviewer suggests replacing this custom alias with Bun's built-in test.if() modifier to improve idiomatic consistency and ensure that other test modifiers like .only or .skip behave correctly across platforms.

} from "./renderer-diagnostics"

let roots: string[] = []
const posixPermissionsTest = process.platform === "win32" ? test.skip : test

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This custom alias can be removed in favor of using Bun's built-in test.if() modifier directly on the test case. This is more idiomatic and avoids the need for manual wrapping of test functions, ensuring consistency with modifiers like .only and .skip.

References
  1. When wrapping test functions to apply custom timeouts or configurations (e.g., for platform-specific stability), ensure that modifiers like .only and .skip are also wrapped to maintain consistent behavior across all test variants and avoid surprises during debugging.

})

test("retention keeps the log intact when the existing file cannot be read", async () => {
posixPermissionsTest("retention keeps the log intact when the existing file cannot be read", async () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of using a custom alias, leverage Bun's built-in test.if() modifier. This approach is more idiomatic and ensures that other test modifiers (such as .only or .skip) behave consistently across all platforms, which aligns with the repository rule regarding test function wrappers.

Suggested change
posixPermissionsTest("retention keeps the log intact when the existing file cannot be read", async () => {
test.if(process.platform !== "win32")("retention keeps the log intact when the existing file cannot be read", async () => {
References
  1. When wrapping test functions to apply custom timeouts or configurations (e.g., for platform-specific stability), ensure that modifiers like .only and .skip are also wrapped to maintain consistent behavior across all test variants and avoid surprises during debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Blocking / highest priority platform Electron shell, OS integration, packaging, updater, signing, paths, and permissions task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant