fix: include release version in installer artifact names - #285
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🧰 Additional context used📓 Path-based instructions (1)packages/app/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (packages/app/AGENTS.md)
Files:
🧠 Learnings (33)📓 Common learnings📚 Learning: 2026-04-20T14:36:04.113ZApplied to files:
📚 Learning: 2026-04-20T14:36:04.113ZApplied to files:
📚 Learning: 2026-04-28T05:36:25.456ZApplied to files:
📚 Learning: 2026-04-28T04:56:21.338ZApplied to files:
📚 Learning: 2026-04-20T14:36:31.032ZApplied to files:
📚 Learning: 2026-04-20T14:36:31.032ZApplied to files:
📚 Learning: 2026-04-24T03:51:56.211ZApplied to files:
📚 Learning: 2026-04-20T14:36:04.113ZApplied to files:
📚 Learning: 2026-04-27T11:19:24.963ZApplied to files:
📚 Learning: 2026-04-20T14:36:04.113ZApplied to files:
📚 Learning: 2026-04-23T07:23:23.849ZApplied to files:
📚 Learning: 2026-04-23T15:10:21.635ZApplied to files:
📚 Learning: 2026-04-28T04:56:13.350ZApplied to files:
📚 Learning: 2026-04-24T17:12:26.774ZApplied to files:
📚 Learning: 2026-04-28T05:36:18.200ZApplied to files:
📚 Learning: 2026-04-28T04:38:11.727ZApplied to files:
📚 Learning: 2026-04-28T04:38:05.946ZApplied to files:
📚 Learning: 2026-04-28T04:56:18.533ZApplied to files:
📚 Learning: 2026-04-28T07:28:14.317ZApplied to files:
📚 Learning: 2026-04-28T08:29:02.858ZApplied to files:
📚 Learning: 2026-04-28T06:51:54.812ZApplied to files:
📚 Learning: 2026-04-28T08:14:31.436ZApplied to files:
📚 Learning: 2026-04-28T07:27:49.810ZApplied to files:
📚 Learning: 2026-04-22T08:49:47.800ZApplied to files:
📚 Learning: 2026-04-28T05:36:24.561ZApplied to files:
📚 Learning: 2026-04-20T14:36:31.032ZApplied to files:
📚 Learning: 2026-04-28T04:38:21.935ZApplied to files:
📚 Learning: 2026-04-21T16:00:44.910ZApplied to files:
📚 Learning: 2026-04-25T12:52:35.631ZApplied to files:
📚 Learning: 2026-04-23T08:51:04.230ZApplied to files:
📚 Learning: 2026-04-28T04:38:11.771ZApplied to files:
📚 Learning: 2026-04-25T09:51:18.951ZApplied to files:
🔇 Additional comments (14)
📝 WalkthroughWalkthroughThe PR updates workspace versions from semantic versioning (0.2.14) to calendar versioning (2026.4.28), includes version numbers in Electron installer artifact filenames, extracts a stable layout memo utility to a dedicated module, and refactors release verification logic to validate CalVer tags and dynamically generate versioned asset names. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request transitions the project to a date-based versioning scheme (2026.4.28) across multiple packages and updates the build configuration to include the version string in artifact filenames. The release verification logic and associated tests have been refactored to support these dynamic asset names. However, a critical issue was identified in the release verification script where the function releaseVersion is called but not defined, which will lead to a runtime error.
Astro-Han
left a comment
There was a problem hiding this comment.
Review Summary
Good change overall — the CalVer migration and dynamic asset naming are well-scoped. A few nits below, mostly around edge cases and test coverage.
Severity Legend
- P0 — Must fix before merge (blocking)
- P1 — Should fix before merge (high confidence)
- P2 — Consider fixing (preference / maintainability)
- P3 — Nitpick / style / optional
Summary
pawwork-${os}-${arch}-${version}.${ext}.2026.4.28.Closes #256.
Verification
bun install --frozen-lockfilebun test electron-builder-app-update.test.ts scripts/verify-release.test.tsfrompackages/desktop-electronbun run typecheck:releasefrompackages/desktop-electronRelease Follow-up
The first CalVer release still needs the release workflow smoke that verifies an installed
v0.2.14app can discover, download, and applyv2026.4.28through auto-update using the renamed assets.Summary by CodeRabbit
Release Notes
Chores