Skip to content

fix: update workflow contract tests for install-matrix job #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 3 commits into from
Jun 18, 2026
Merged

fix: update workflow contract tests for install-matrix job #1355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f088b62
fix: update workflow contract tests for install-matrix job
Astro-Han Jun 17, 2026
a1403d7
test: add precise install-matrix contract assertions
Astro-Han Jun 17, 2026
d4bbda3
fix: narrow desktop smoke workflow matrix assertion
Astro-Han Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/desktop-smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # oven-sh/setup-bun@v2
with:
# Load-bearing for `bun audit` exit semantics; do not bump without re-verifying advisory exit codes.
bun-version: "1.3.14"

- uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # actions/cache@v5
Expand Down
21 changes: 11 additions & 10 deletions packages/opencode/test/github/bun-version-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe("GitHub workflow Bun version pin", () => {
}

expect(collectSetupBunPins(workflow, "synthetic.yml")).toEqual([
"synthetic.yml:unpinned:step-1:bun-version: \"<missing>\"",
'synthetic.yml:unpinned:step-1:bun-version: "<missing>"',
])
})

Expand Down Expand Up @@ -83,15 +83,16 @@ describe("GitHub workflow Bun version pin", () => {
}

expect(setupBunPins).toEqual([
".github/workflows/build.yml:build-electron:step-5:bun-version: \"1.3.14\"",
".github/workflows/deploy-site.yml:build-and-deploy:step-2:bun-version: \"1.3.14\"",
".github/workflows/desktop-smoke.yml:smoke-macos-arm64:step-3:bun-version: \"1.3.14\"",
".github/workflows/dev-dep-audit.yml:dev-dep-audit:step-3:bun-version: \"1.3.14\"",
".github/workflows/e2e-artifacts.yml:e2e-artifacts:step-3:bun-version: \"1.3.14\"",
".github/workflows/mirror-release-to-r2.yml:mirror:step-2:bun-version: \"1.3.14\"",
".github/workflows/officecli-bump.yml:officecli-bump:step-3:bun-version: \"1.3.14\"",
".github/workflows/perf-probe-baseline.yml:perf-probe-baseline:step-7:bun-version: \"1.3.14\"",
".github/workflows/windows-advisory.yml:unit-windows:step-3:bun-version: \"1.3.14\"",
'.github/workflows/build.yml:build-electron:step-5:bun-version: "1.3.14"',
'.github/workflows/deploy-site.yml:build-and-deploy:step-2:bun-version: "1.3.14"',
'.github/workflows/desktop-smoke.yml:smoke-macos-arm64:step-3:bun-version: "1.3.14"',
'.github/workflows/desktop-smoke.yml:install-matrix:step-3:bun-version: "1.3.14"',
'.github/workflows/dev-dep-audit.yml:dev-dep-audit:step-3:bun-version: "1.3.14"',
'.github/workflows/e2e-artifacts.yml:e2e-artifacts:step-3:bun-version: "1.3.14"',
'.github/workflows/mirror-release-to-r2.yml:mirror:step-2:bun-version: "1.3.14"',
'.github/workflows/officecli-bump.yml:officecli-bump:step-3:bun-version: "1.3.14"',
'.github/workflows/perf-probe-baseline.yml:perf-probe-baseline:step-7:bun-version: "1.3.14"',
'.github/workflows/windows-advisory.yml:unit-windows:step-3:bun-version: "1.3.14"',
])
expect(missingComments).toEqual([])

Expand Down
7 changes: 2 additions & 5 deletions packages/opencode/test/github/desktop-smoke-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe("desktop smoke workflow", () => {
expect(parsed.concurrency?.group).toContain("github.event.pull_request.number || github.ref")
expect(parsed.concurrency?.["cancel-in-progress"]).toBe("${{ github.ref != 'refs/heads/dev' }}")
expect(parsed.permissions).toEqual({ contents: "read", "pull-requests": "read" })
expect(Object.keys(jobs).sort()).toEqual(["changes", "check", "smoke-macos-arm64"])
expect(Object.keys(jobs).sort()).toEqual(["changes", "check", "install-matrix", "smoke-macos-arm64"])
expect(changesCheckoutStep?.uses).toBe("actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd")
expect(smokeCheckoutStep?.uses).toBe("actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd")

Expand All @@ -67,10 +67,7 @@ describe("desktop smoke workflow", () => {
expect(smoke?.if).toBe("needs.changes.outputs.docs_only != 'true'")
expect(smoke?.["runs-on"]).toBe("macos-14")
expect(check?.if).toBe("always()")
expect(check?.needs).toEqual(["changes", "smoke-macos-arm64"])

expect(workflow).not.toContain("strategy:")
expect(workflow).not.toContain("matrix:")
expect(check?.needs).toEqual(["changes", "smoke-macos-arm64", "install-matrix"])

expect(smokeCheckoutStep?.with).toEqual({ "persist-credentials": false })
expect(smokeBunStep?.uses).toBe("oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6")
Expand Down
Loading