fix: update workflow contract tests for install-matrix job

.github/workflows/desktop-smoke.yml

@@ -282,6 +282,7 @@ jobs:
 
       - uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # oven-sh/setup-bun@v2
         with:
+          # Load-bearing for `bun audit` exit semantics; do not bump without re-verifying advisory exit codes.
           bun-version: "1.3.14"
 
       - uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # actions/cache@v5

packages/opencode/test/github/bun-version-workflow.test.ts

@@ -48,7 +48,7 @@ describe("GitHub workflow Bun version pin", () => {
     }
 
     expect(collectSetupBunPins(workflow, "synthetic.yml")).toEqual([
-      "synthetic.yml:unpinned:step-1:bun-version: \"<missing>\"",
+      'synthetic.yml:unpinned:step-1:bun-version: "<missing>"',
     ])
   })
 
@@ -83,15 +83,16 @@ describe("GitHub workflow Bun version pin", () => {
     }
 
     expect(setupBunPins).toEqual([
-      ".github/workflows/build.yml:build-electron:step-5:bun-version: \"1.3.14\"",
-      ".github/workflows/deploy-site.yml:build-and-deploy:step-2:bun-version: \"1.3.14\"",
-      ".github/workflows/desktop-smoke.yml:smoke-macos-arm64:step-3:bun-version: \"1.3.14\"",
-      ".github/workflows/dev-dep-audit.yml:dev-dep-audit:step-3:bun-version: \"1.3.14\"",
-      ".github/workflows/e2e-artifacts.yml:e2e-artifacts:step-3:bun-version: \"1.3.14\"",
-      ".github/workflows/mirror-release-to-r2.yml:mirror:step-2:bun-version: \"1.3.14\"",
-      ".github/workflows/officecli-bump.yml:officecli-bump:step-3:bun-version: \"1.3.14\"",
-      ".github/workflows/perf-probe-baseline.yml:perf-probe-baseline:step-7:bun-version: \"1.3.14\"",
-      ".github/workflows/windows-advisory.yml:unit-windows:step-3:bun-version: \"1.3.14\"",
+      '.github/workflows/build.yml:build-electron:step-5:bun-version: "1.3.14"',
+      '.github/workflows/deploy-site.yml:build-and-deploy:step-2:bun-version: "1.3.14"',
+      '.github/workflows/desktop-smoke.yml:smoke-macos-arm64:step-3:bun-version: "1.3.14"',
+      '.github/workflows/desktop-smoke.yml:install-matrix:step-3:bun-version: "1.3.14"',
+      '.github/workflows/dev-dep-audit.yml:dev-dep-audit:step-3:bun-version: "1.3.14"',
+      '.github/workflows/e2e-artifacts.yml:e2e-artifacts:step-3:bun-version: "1.3.14"',
+      '.github/workflows/mirror-release-to-r2.yml:mirror:step-2:bun-version: "1.3.14"',
+      '.github/workflows/officecli-bump.yml:officecli-bump:step-3:bun-version: "1.3.14"',
+      '.github/workflows/perf-probe-baseline.yml:perf-probe-baseline:step-7:bun-version: "1.3.14"',
+      '.github/workflows/windows-advisory.yml:unit-windows:step-3:bun-version: "1.3.14"',
     ])
     expect(missingComments).toEqual([])
 

packages/opencode/test/github/desktop-smoke-workflow.test.ts

@@ -43,7 +43,7 @@ describe("desktop smoke workflow", () => {
     expect(parsed.concurrency?.group).toContain("github.event.pull_request.number || github.ref")
     expect(parsed.concurrency?.["cancel-in-progress"]).toBe("${{ github.ref != 'refs/heads/dev' }}")
     expect(parsed.permissions).toEqual({ contents: "read", "pull-requests": "read" })
-    expect(Object.keys(jobs).sort()).toEqual(["changes", "check", "smoke-macos-arm64"])
+    expect(Object.keys(jobs).sort()).toEqual(["changes", "check", "install-matrix", "smoke-macos-arm64"])
     expect(changesCheckoutStep?.uses).toBe("actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd")
     expect(smokeCheckoutStep?.uses).toBe("actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd")
 
@@ -67,10 +67,35 @@ describe("desktop smoke workflow", () => {
     expect(smoke?.if).toBe("needs.changes.outputs.docs_only != 'true'")
     expect(smoke?.["runs-on"]).toBe("macos-14")
     expect(check?.if).toBe("always()")
-    expect(check?.needs).toEqual(["changes", "smoke-macos-arm64"])
+    expect(check?.needs).toEqual(["changes", "smoke-macos-arm64", "install-matrix"])
 
-    expect(workflow).not.toContain("strategy:")
-    expect(workflow).not.toContain("matrix:")
+    // install-matrix job: validates Electron install on Node 24 and 26
+    const install = jobs["install-matrix"]
+    const installSteps = install?.steps ?? []
+    expect(install?.needs).toBe("changes")
+    expect(install?.if).toBe("needs.changes.outputs.docs_only != 'true'")
+    expect(install?.["runs-on"]).toBe("macos-14")
+    expect(install?.["timeout-minutes"]).toBe(10)
+    const installMatrix = install?.strategy?.matrix as { "node-version"?: unknown } | undefined
+    expect(installMatrix?.["node-version"]).toEqual(["24", "26"])
+    const installCheckout = installSteps.find((step) => step.uses?.startsWith("actions/checkout@"))
+    expect(installCheckout?.with?.["persist-credentials"]).toBe(false)
+    const installSetupNode = installSteps.find((step) => step.uses?.startsWith("actions/setup-node@"))
+    expect(installSetupNode?.with?.["node-version"]).toBe("${{ matrix.node-version }}")
+    const installBunStep = installSteps.find((step) => step.uses?.startsWith("oven-sh/setup-bun@"))
+    expect(installBunStep?.with?.["bun-version"]).toBe("1.3.14")
+    const installDepsStep = installSteps.find((step) => step.name === "Install dependencies")
+    expect(installDepsStep?.run).toBe("bun install --frozen-lockfile")
+    const assertStep = installSteps.find((step) => step.name === "Assert Electron install complete")
+    expect(assertStep?.run).toBe("node ./scripts/repair-electron-install.mjs --assert-complete")
+    expect(assertStep?.["working-directory"]).toBe("packages/desktop-electron")
+
+    // smoke-macos-arm64 must not use strategy/matrix (install-matrix is the only job that does)
+    expect(workflow).toContain("strategy:")
+    expect(workflow).toContain("matrix:")
+    const smokeRaw = workflow.slice(workflow.indexOf("smoke-macos-arm64:"), workflow.indexOf("install-matrix:"))
+    expect(smokeRaw).not.toContain("strategy:")
+    expect(smokeRaw).not.toContain("matrix:")
 
     expect(smokeCheckoutStep?.with).toEqual({ "persist-credentials": false })
     expect(smokeBunStep?.uses).toBe("oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6")