Skip to content

fix(desktop): update OpenCLI third-party notice - #1337

Merged
Astro-Han merged 2 commits into
devfrom
codex/opencli-notices-fix
Jun 16, 2026
Merged

fix(desktop): update OpenCLI third-party notice#1337
Astro-Han merged 2 commits into
devfrom
codex/opencli-notices-fix

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Summary

Update the root third-party notices entry for bundled OpenCLI from 1.8.3 to 1.8.4, and teach PR triage to route root third-party notice changes to the platform area.

This is a post-merge follow-up to #1315; there is no separate issue because the dev branch CI failure identified the missing notice update immediately after that merge.

Why

unit-desktop on dev failed because packages/opencode/package.json now depends on @jackwener/opencli 1.8.4 while THIRD_PARTY_NOTICES.md still reported 1.8.3.

The follow-up PR itself also exposed that THIRD_PARTY_NOTICES.md had no labeler routing rule, so pr-triage removed manual routing labels and failed policy. Since the notices file is packaged by the desktop app, it belongs under platform.

Related Issue

Follow-up to #1315.

Human Review Status

Pending

Review Focus

Confirm the notice version matches the OpenCLI dependency bumped in #1315, and that root third-party notice changes are routed as platform PRs.

Risk Notes

No product behavior risk. This updates bundled third-party attribution text and a PR-triage labeler rule. No visible UI check is needed because the packaged notice file changes, not app UI copy.

How To Verify

RED: cd packages/desktop-electron && bun test ./electron-builder-app-update.test.ts failed with Expected to contain: "Version: 1.8.4".
GREEN: cd packages/desktop-electron && bun test ./electron-builder-app-update.test.ts passed, 19 tests.
RED: cd packages/opencode && bun test ./test/github/pr-triage-workflow.test.ts failed because THIRD_PARTY_NOTICES.md had no platform route.
GREEN: cd packages/opencode && bun test ./test/github/pr-triage-workflow.test.ts passed, 12 tests.
Related CI surface: cd packages/desktop-electron && bun run test:ci passed, 529 tests plus CDP smoke.

Screenshots or Recordings

Not applicable; no visible UI changed.

Checklist

How to use this checklist:

  • Tick a box by replacing [ ] with [x]. Do not edit, add, or remove items.
  • The bot-applied label items can only be honestly ticked AFTER the PR is opened and the labeler / priority-triage bots have run — return to the PR description and tick them then.
  • Most items are required. The few that are conditional are explicitly marked (conditional); for those, leave unticked if they truly do not apply and explain why in Risk Notes. All other items must be ticked before requesting human review.
  • Type label — this PR carries exactly one of bug, enhancement, task, documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.
  • Routing labels — this PR carries at least one of app, ui, platform, harness, ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.
  • Priority label — this PR carries exactly one of P0, P1, P2, P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.
  • Human Review Status above is set to Pending, Approved by @<reviewer>, or Not required: <reason> (default is Pending; "not required" is restricted to bot-authored low-risk PRs).
  • I linked the related issue, or stated in Summary why there is no issue.
  • I described the review focus and any meaningful risks.
  • I replaced the example block in How To Verify with the real verification steps and the key result for each.
  • I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope.
  • (conditional) I manually checked visible UI or copy changes when needed, with screenshots or recordings. Leave unticked only if no visible UI or copy changed.
  • (conditional) I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes. Leave unticked only if no platform/packaging surface was touched.
  • (conditional) I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant. Leave unticked only if none of those surfaces was touched.
  • I reviewed the final diff for unrelated changes and suspicious dependency changes.
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English.

@Astro-Han Astro-Han added bug Something isn't working platform Electron shell, OS integration, packaging, updater, signing, paths, and permissions ci Continuous integration / GitHub Actions P2 Medium priority labels Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Astro-Han, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 32 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ca5e00cc-f9cc-444f-aa50-26118a07fff7

📥 Commits

Reviewing files that changed from the base of the PR and between a1e9de0 and b961c60.

📒 Files selected for processing (3)
  • .github/labeler.yml
  • THIRD_PARTY_NOTICES.md
  • packages/opencode/test/github/pr-triage-workflow.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/opencli-notices-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot removed ci Continuous integration / GitHub Actions platform Electron shell, OS integration, packaging, updater, signing, paths, and permissions labels Jun 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of @jackwener/opencli from 1.8.3 to 1.8.4 in the THIRD_PARTY_NOTICES.md file. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested priority: P3 (only low-risk paths changed (THIRD_PARTY_NOTICES.md)).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

@Astro-Han Astro-Han added platform Electron shell, OS integration, packaging, updater, signing, paths, and permissions ci Continuous integration / GitHub Actions labels Jun 16, 2026
@github-actions github-actions Bot removed ci Continuous integration / GitHub Actions platform Electron shell, OS integration, packaging, updater, signing, paths, and permissions labels Jun 16, 2026
@github-actions github-actions Bot added ci Continuous integration / GitHub Actions harness Model harness, prompts, tool descriptions, and session mechanics labels Jun 16, 2026
@Astro-Han
Astro-Han merged commit 0909877 into dev Jun 16, 2026
35 checks passed
@Astro-Han
Astro-Han deleted the codex/opencli-notices-fix branch June 16, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous integration / GitHub Actions harness Model harness, prompts, tool descriptions, and session mechanics P2 Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant