feat(opencli): add Xiaohongshu ask via upstream 1.8.4 - #1315
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughBumps Changesopencli 1.8.4 bump and Xiaohongshu test coverage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a new adapter override for Xiaohongshu's "ask" command (xiaohongshu-ask.ts), which interacts with the site's webpack conversation store to query "点点" and retrieve answers along with citation sources. The adapter is registered in adapter-registry.ts, and corresponding integration tests have been added to verify its discovery and functionality. I have no feedback to provide as there are no review comments and the implementation is complete.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
## Summary - Update `THIRD_PARTY_NOTICES.md` so bundled OpenCLI attribution reports version 1.8.4 after #1315. - Route root third-party notice changes through the `platform` labeler rule, with a workflow contract test, so notice-only PRs satisfy PR triage after this lands. ## Verification - RED: `cd packages/desktop-electron && bun test ./electron-builder-app-update.test.ts` failed with `Expected to contain: "Version: 1.8.4"`. - GREEN: `cd packages/desktop-electron && bun test ./electron-builder-app-update.test.ts` passed, 19 tests. - RED: `cd packages/opencode && bun test ./test/github/pr-triage-workflow.test.ts` failed because `THIRD_PARTY_NOTICES.md` had no platform route. - GREEN: `cd packages/opencode && bun test ./test/github/pr-triage-workflow.test.ts` passed, 12 tests. - `cd packages/desktop-electron && bun run test:ci` passed, 529 tests plus CDP smoke. - PR CI passed, including `unit-desktop`, `pr-triage`, `dev-dep-audit`, and Windows advisory. ## Risk Low. This corrects packaged attribution text and a PR labeler route; no product runtime behavior changes.
Summary
Bumps
@jackwener/openclifrom1.8.3to1.8.4so PawWork gets the upstreamxiaohongshu/askadapter from the published package.There is no related issue; this updates PawWork's pinned OpenCLI integration after OpenCLI released
v1.8.4with the Xiaohongshu 点点 command.Why
The original PR used a PawWork-local overlay because OpenCLI had not published the adapter yet. OpenCLI
v1.8.4is now published and its npm package includes bothclis/xiaohongshu/ask.jsand the manifest entry, so the local overlay has been removed in favor of the dependency bump.Related Issue
No issue.
Human Review Status
Pending
Review Focus
Please focus on whether the final diff stays limited to the OpenCLI dependency bump and public adapter discovery coverage, and whether
xiaohongshu/askis verified through both source tests and the built embedded-server artifact.Risk Notes
This changes PawWork's pinned OpenCLI package from
1.8.3to1.8.4. The previous local overlay source and overlay-only tests were removed because the adapter now comes from the upstream package.No visible UI changed, so no screenshots are included. The desktop embedded-server packaging path is covered by the built-node OpenCLI adapter test.
How To Verify
Screenshots or Recordings
Not required; no visible UI changed.
Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.Summary by CodeRabbit
Chores
Tests