fix(manifest): declare recorder after_dependency#84
Merged
Conversation
__init__.py imports homeassistant.components.recorder.{get_instance, history}
at lines 100-101 for backfill history queries. hassfest@master correctly
flagged the missing manifest declaration, failing the scheduled Validation
workflow on main for 8 consecutive days (2026-05-13 through 2026-05-20).
dev already carries this fix (manifest at v1.5.0-beta.2 includes
after_dependencies: ["recorder"]); main was missing it because main has not
been merged forward since v1.3.0.
Restores green Validation on main without backporting any feature work from
dev. Separate decision pending on whether to merge dev → main in full.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8 tasks
This was referenced May 23, 2026
Artic0din
added a commit
that referenced
this pull request
May 23, 2026
…CI (#143) Four findings from a 2026-05-23 @claude retro-review of merged PRs. - providers/openelectricity.py: ``_is_auth_error`` no longer matches the bare word ``forbidden`` in exception messages — TLS/corporate-proxy errors with that word were mis-classified as ``ConfigEntryAuthFailed``, prompting users to re-enter their API key when the real problem is connectivity. Auth detection now keys on auth-specific message tokens (401, unauthorized, invalid api key); the class-name check still catches genuine ``*Forbidden*`` exception types. New regression test test_tls_error_with_forbidden_word_is_not_auth_failure. (Retro #86) - tests/test_tariff_engine_hypothesis.py: three property tests used ``if k <= threshold: return`` to early-exit out-of-range draws, which Hypothesis treats as PASSED rather than discarded. With max_examples=200 and ~75% of draws hitting the early return, the effective constrained-region coverage was ~50 examples per invariant instead of 200. Switched to ``assume(k > threshold)`` / ``assume(k < threshold)`` / ``assume(k >= threshold)`` so Hypothesis discards and regenerates until 200 valid examples are spent in the interesting region. Tolerance also aligned to 1e-9 across invariants 2 + 3 (single bounded-float multiplications have round-trip error < ~4e-12, so the tight value is safe). (Retro #102) - .github/workflows/dual-loop-review.yml: dropped ``develop`` from the pull_request branches filter — ``gh api repos/.../branches`` confirms no ``develop`` branch exists; it was a stale alias from the template that silently never matched. Filter now ``[main, dev]``. (Retro #103) PR #84 review noted no issues (after_dependencies fix verified correct); no change here for that PR. Full test suite: 1119 passing locally.
Artic0din
added a commit
that referenced
this pull request
May 27, 2026
Resolution policy: - Workflows + CODEOWNERS + slash commands + ENGINEERING_CONSTITUTION.md + mypy.ini → take main's version (the migration's intent). - Source files (backfill.py, config_flow.py) → take dev's version (dev has 60 commits of newer source supersending main's mypy type-ignore comments, which no longer apply to the dev versions). - CHANGELOG.md → preserve dev's beta history, inject main's [Unreleased] block at the top. - 5 legacy workflows deleted per main's intent. This brings the new ci.yml + mypy.ini onto dev so the 16 open dev-targeting PRs run under the consolidated CI once rebased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"after_dependencies": ["recorder"]tocustom_components/pricehawk/manifest.json.main(2026-05-13 → 2026-05-20).Root cause
custom_components/pricehawk/__init__.py:100-101imports:hassfest@mastercorrectly flags this as[ERROR] [DEPENDENCIES] Using component recorder but it's not in 'dependencies' or 'after_dependencies'.dev(v1.5.0-beta.2) already carries the fix;main(v1.3.0) was left behind because the branch has not been merged forward.Scope
One-line manifest addition. No source code changes. No feature work backported from
dev.Out of scope
Whether to merge
dev → mainin full (21+ commits) is a separate release-management decision and is not addressed here.Test plan
Validationrun onmain(00:00 UTC) is green.🤖 Generated with Claude Code