ci: include dev branch in dual-loop-review PR-target gate#103
Merged
Conversation
Narrow scope: only edits dual-loop-review.yml (the Claude AI review workflow). PRs targeting dev now trigger Claude review, which is the core need for the stacked v3.0 PR series. The other 5 workflows (python-ci, pr-checks, lint, docs-check, security-scan) also have the same `[main, develop]` gate but expose pre-existing failures when extended to dev: - python-ci.yml mypy: 27 baseline type errors in tests - pr-checks.yml: CodeRabbit gate still checks for CR approval despite CLAUDE.md saying CR is not used - security-scan.yml gitleaks: flags string-literal test secrets in tests/test_reauth.py + others; needs allowlist for test fixtures - dual-loop-review run for THIS PR hit an upstream tsconfig directory-mismatch bug in the anthropics/claude-code-action@v1 action; transient Each is a separate cleanup PR. Landing this narrow change unblocks the Claude AI review path for the 17 stacked PRs without sweeping unrelated debt under the rug. After merge: the 17 stacked PRs (#87..#102) trigger dual-loop-review on next synchronize (push, rebase, or empty commit). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Artic0din
force-pushed
the
chore/workflow-add-dev-branch-gate
branch
from
f55e259 to
58ee0b2
Compare
Artic0din
changed the title
7 tasks
This was referenced May 23, 2026
Artic0din
added a commit
that referenced
this pull request
May 23, 2026
…CI (#143) Four findings from a 2026-05-23 @claude retro-review of merged PRs. - providers/openelectricity.py: ``_is_auth_error`` no longer matches the bare word ``forbidden`` in exception messages — TLS/corporate-proxy errors with that word were mis-classified as ``ConfigEntryAuthFailed``, prompting users to re-enter their API key when the real problem is connectivity. Auth detection now keys on auth-specific message tokens (401, unauthorized, invalid api key); the class-name check still catches genuine ``*Forbidden*`` exception types. New regression test test_tls_error_with_forbidden_word_is_not_auth_failure. (Retro #86) - tests/test_tariff_engine_hypothesis.py: three property tests used ``if k <= threshold: return`` to early-exit out-of-range draws, which Hypothesis treats as PASSED rather than discarded. With max_examples=200 and ~75% of draws hitting the early return, the effective constrained-region coverage was ~50 examples per invariant instead of 200. Switched to ``assume(k > threshold)`` / ``assume(k < threshold)`` / ``assume(k >= threshold)`` so Hypothesis discards and regenerates until 200 valid examples are spent in the interesting region. Tolerance also aligned to 1e-9 across invariants 2 + 3 (single bounded-float multiplications have round-trip error < ~4e-12, so the tight value is safe). (Retro #102) - .github/workflows/dual-loop-review.yml: dropped ``develop`` from the pull_request branches filter — ``gh api repos/.../branches`` confirms no ``develop`` branch exists; it was a stale alias from the template that silently never matched. Filter now ``[main, dev]``. (Retro #103) PR #84 review noted no issues (after_dependencies fix verified correct); no change here for that PR. Full test suite: 1119 passing locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six workflows were gated on
[main, develop]but the repo's integration branch isdev. PRs targetingdevwere silently bypassing dual-loop-review, pytest CI, lint, docs-check, security-scan. Only Validation (no gate) ran. This addsdevto the gate list for all 6. After merge, PRs #87..#102 will retrigger full CI on next sync.